search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.28k stars 2.63k forks source link

enhance: add more trace for search & query #32734

Closed longjiquan closed 2 weeks ago

longjiquan commented 3 weeks ago

issue: https://github.com/milvus-io/milvus/issues/32728

mergify[bot] commented 3 weeks ago

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] commented 3 weeks ago

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] commented 2 weeks ago

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 2 weeks ago

@longjiquan ut workflow job failed, comment rerun ut can trigger the job again.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.72%. Comparing base (83ce352) to head (99adcea). Report is 9 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32734/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32734 +/- ## ========================================== - Coverage 81.77% 81.72% -0.06% ========================================== Files 1001 1001 Lines 125359 125450 +91 ========================================== + Hits 102517 102519 +2 - Misses 18956 19018 +62 - Partials 3886 3913 +27 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/core/src/segcore/Reduce.cpp](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&filepath=internal%2Fcore%2Fsrc%2Fsegcore%2FReduce.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvY29yZS9zcmMvc2VnY29yZS9SZWR1Y2UuY3Bw) | `93.18% <100.00%> (+0.13%)` | :arrow_up: | | [internal/core/src/segcore/Reduce.h](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&filepath=internal%2Fcore%2Fsrc%2Fsegcore%2FReduce.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvY29yZS9zcmMvc2VnY29yZS9SZWR1Y2UuaA==) | `100.00% <100.00%> (ø)` | | | [internal/core/src/segcore/SegmentInterface.h](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&filepath=internal%2Fcore%2Fsrc%2Fsegcore%2FSegmentInterface.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvY29yZS9zcmMvc2VnY29yZS9TZWdtZW50SW50ZXJmYWNlLmg=) | `100.00% <ø> (ø)` | | | [internal/core/src/segcore/reduce\_c.cpp](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&filepath=internal%2Fcore%2Fsrc%2Fsegcore%2Freduce_c.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvY29yZS9zcmMvc2VnY29yZS9yZWR1Y2VfYy5jcHA=) | `68.65% <100.00%> (+1.99%)` | :arrow_up: | | [internal/proxy/task\_search.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&filepath=internal%2Fproxy%2Ftask_search.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcHJveHkvdGFza19zZWFyY2guZ28=) | `77.46% <100.00%> (+0.22%)` | :arrow_up: | | [internal/querynodev2/segments/reduce.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Freduce.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvcmVkdWNlLmdv) | `75.90% <100.00%> (+0.29%)` | :arrow_up: | | [internal/querynodev2/segments/result.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fresult.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvcmVzdWx0Lmdv) | `74.75% <100.00%> (+0.74%)` | :arrow_up: | | [internal/core/src/segcore/segment\_c.cpp](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&filepath=internal%2Fcore%2Fsrc%2Fsegcore%2Fsegment_c.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvY29yZS9zcmMvc2VnY29yZS9zZWdtZW50X2MuY3Bw) | `57.79% <50.00%> (-0.23%)` | :arrow_down: | | [internal/core/src/segcore/SegmentInterface.cpp](https://app.codecov.io/gh/milvus-io/milvus/pull/32734?src=pr&el=tree&filepath=internal%2Fcore%2Fsrc%2Fsegcore%2FSegmentInterface.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvY29yZS9zcmMvc2VnY29yZS9TZWdtZW50SW50ZXJmYWNlLmNwcA==) | `88.50% <62.50%> (-0.39%)` | :arrow_down: | ... and [27 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32734/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
mergify[bot] commented 2 weeks ago

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 2 weeks ago

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

longjiquan commented 2 weeks ago

/run-cpu-e2e

mergify[bot] commented 2 weeks ago

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

czs007 commented 2 weeks ago

/approve /lgtm

sre-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/core/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/core/OWNERS)~~ [czs007] - ~~[internal/proxy/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/proxy/OWNERS)~~ [czs007] - ~~[internal/querynodev2/segments/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/querynodev2/segments/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment