milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.29k stars 2.63k forks source link

fix: Make the dynamic column optional in parquet import #32738

Closed bigsheeper closed 2 weeks ago

bigsheeper commented 3 weeks ago

issue: https://github.com/milvus-io/milvus/issues/32729

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.78%. Comparing base (77f4f0c) to head (38d81f7). Report is 23 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32738/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32738 +/- ## ========================================== + Coverage 81.72% 81.78% +0.05% ========================================== Files 998 999 +1 Lines 125433 124297 -1136 ========================================== - Hits 102510 101653 -857 + Misses 19075 18777 -298 - Partials 3848 3867 +19 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32738?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/util/importutilv2/numpy/reader.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32738?src=pr&el=tree&filepath=internal%2Futil%2Fimportutilv2%2Fnumpy%2Freader.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvdXRpbC9pbXBvcnR1dGlsdjIvbnVtcHkvcmVhZGVyLmdv) | `73.07% <100.00%> (ø)` | | | [internal/util/importutilv2/numpy/util.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32738?src=pr&el=tree&filepath=internal%2Futil%2Fimportutilv2%2Fnumpy%2Futil.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvdXRpbC9pbXBvcnR1dGlsdjIvbnVtcHkvdXRpbC5nbw==) | `42.65% <ø> (-6.75%)` | :arrow_down: | | [internal/util/importutilv2/parquet/util.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32738?src=pr&el=tree&filepath=internal%2Futil%2Fimportutilv2%2Fparquet%2Futil.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvdXRpbC9pbXBvcnR1dGlsdjIvcGFycXVldC91dGlsLmdv) | `74.44% <100.00%> (+0.84%)` | :arrow_up: | | [internal/util/importutilv2/parquet/reader.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32738?src=pr&el=tree&filepath=internal%2Futil%2Fimportutilv2%2Fparquet%2Freader.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvdXRpbC9pbXBvcnR1dGlsdjIvcGFycXVldC9yZWFkZXIuZ28=) | `65.71% <33.33%> (-1.45%)` | :arrow_down: | | [internal/util/importutilv2/common/util.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32738?src=pr&el=tree&filepath=internal%2Futil%2Fimportutilv2%2Fcommon%2Futil.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvdXRpbC9pbXBvcnR1dGlsdjIvY29tbW9uL3V0aWwuZ28=) | `88.00% <88.00%> (ø)` | | ... and [138 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32738/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
czs007 commented 2 weeks ago

/approve /lgtm

sre-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus/blob/master/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment