search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.29k stars 2.63k forks source link

fix: Remove empty assert of insert_record. #32743

Closed v1incent closed 3 weeks ago

v1incent commented 3 weeks ago

For pk field, it was not allowed to firstly load the index and then load the field data. This RP removed the limitation.

sre-ci-robot commented 3 weeks ago

Welcome @v1incent! It looks like this is your first PR to milvus-io/milvus 🎉

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: v1incent To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed. You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[internal/core/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/core/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 3 weeks ago

@v1incent Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

mergify[bot] commented 3 weeks ago

@v1incent Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)