search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.32k stars 2.63k forks source link

Revert "enhance: trigger compaction by size (#32326)" #32745

Closed tedxu closed 3 weeks ago

tedxu commented 3 weeks ago

This reverts commit fef78122546ca7fd68485c9dfd7d00f6318d6eba.

mergify[bot] commented 3 weeks ago

@tedxu Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

mergify[bot] commented 3 weeks ago

@tedxu

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:

    • feat: for introducing a new feature.
    • fix: for bug fixes.
    • enhance: for improvements to existing functionality.
    • test: for add tests to existing functionality.
    • doc: for modifying documentation.
    • auto: for the pull request from bot.

  2. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

czs007 commented 3 weeks ago

/approve /lgtm

sre-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/datacoord/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/internal/datacoord/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 85.41667% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 81.76%. Comparing base (51e0855) to head (723137c). Report is 384 commits behind head on 2.4.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32745/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #32745 +/- ## ========================================== + Coverage 81.58% 81.76% +0.17% ========================================== Files 976 998 +22 Lines 120147 124375 +4228 ========================================== + Hits 98019 101689 +3670 - Misses 18396 18809 +413 - Partials 3732 3877 +145 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32745?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/datacoord/compaction\_trigger.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32745?src=pr&el=tree&filepath=internal%2Fdatacoord%2Fcompaction_trigger.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvZGF0YWNvb3JkL2NvbXBhY3Rpb25fdHJpZ2dlci5nbw==) | `83.08% <85.41%> (ø)` | | ... and [259 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32745/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)