milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.32k stars 2.63k forks source link

enhance: Add `metautil.Channel` to convert string compare to int #32749

Closed congqixia closed 2 weeks ago

congqixia commented 3 weeks ago

See also #32748

This PR:

mergify[bot] commented 3 weeks ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 3 weeks ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 3 weeks ago

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] commented 3 weeks ago

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

mergify[bot] commented 3 weeks ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 3 weeks ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia commented 3 weeks ago

/run-cpu-e2e

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 82.47423% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 81.74%. Comparing base (600db9d) to head (836d138). Report is 21 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/32749/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/32749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #32749 +/- ## ========================================== - Coverage 81.77% 81.74% -0.04% ========================================== Files 1001 1002 +1 Lines 125359 125437 +78 ========================================== + Hits 102508 102534 +26 - Misses 18966 18996 +30 - Partials 3885 3907 +22 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/32749?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querynodev2/segments/segment\_loader.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32749?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fsegment_loader.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvc2VnbWVudF9sb2FkZXIuZ28=) | `71.84% <100.00%> (ø)` | | | [internal/querynodev2/services.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32749?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fservices.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VydmljZXMuZ28=) | `90.61% <100.00%> (ø)` | | | [internal/querynodev2/segments/segment\_l0.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32749?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fsegment_l0.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvc2VnbWVudF9sMC5nbw==) | `64.86% <50.00%> (-1.34%)` | :arrow_down: | | [internal/querynodev2/segments/manager.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32749?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fmanager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvbWFuYWdlci5nbw==) | `76.03% <50.00%> (-0.45%)` | :arrow_down: | | [internal/querynodev2/segments/segment.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32749?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fsegment.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvc2VnbWVudC5nbw==) | `66.83% <75.00%> (-0.25%)` | :arrow_down: | | [pkg/util/metautil/channel.go](https://app.codecov.io/gh/milvus-io/milvus/pull/32749?src=pr&el=tree&filepath=pkg%2Futil%2Fmetautil%2Fchannel.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-cGtnL3V0aWwvbWV0YXV0aWwvY2hhbm5lbC5nbw==) | `89.83% <89.83%> (ø)` | | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/32749/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
xiaofan-luan commented 2 weeks ago

/lgtm /approve

sre-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/querynodev2/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/querynodev2/OWNERS)~~ [congqixia,xiaofan-luan] - ~~[pkg/util/OWNERS](https://github.com/milvus-io/milvus/blob/master/pkg/util/OWNERS)~~ [congqixia,xiaofan-luan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 2 weeks ago

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

congqixia commented 2 weeks ago

@Mergifyio refresh

mergify[bot] commented 2 weeks ago

refresh

✅ Pull request refreshed

weiliu1031 commented 2 weeks ago

/lgtm