search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
27.58k stars 2.66k forks source link

enhance: mmap load raw data if scalar index does not have raw data #33175

Closed sunby closed 1 week ago

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.20%. Comparing base (c35eaaa) to head (761145b). Report is 7 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/33175/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/33175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #33175 +/- ## ========================================== + Coverage 82.17% 82.20% +0.03% ========================================== Files 1009 1009 Lines 128822 128822 ========================================== + Hits 105856 105898 +42 + Misses 18961 18934 -27 + Partials 4005 3990 -15 ``` | [Files](https://app.codecov.io/gh/milvus-io/milvus/pull/33175?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querynodev2/segments/segment.go](https://app.codecov.io/gh/milvus-io/milvus/pull/33175?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fsegment.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvc2VnbWVudC5nbw==) | `67.14% <100.00%> (ø)` | | | [internal/querynodev2/segments/segment\_loader.go](https://app.codecov.io/gh/milvus-io/milvus/pull/33175?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fsegments%2Fsegment_loader.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VnbWVudHMvc2VnbWVudF9sb2FkZXIuZ28=) | `73.42% <66.66%> (ø)` | | ... and [30 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/33175/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)
czs007 commented 1 week ago

/approve

sre-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/querynodev2/segments/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/querynodev2/segments/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
czs007 commented 1 week ago

/lgtm