[Bug]: [GoSDK] Create binary vector collection with invalid dim returns no error

[ThreadDao]

Is there an existing issue for this?

• [X] I have searched the existing issues

Environment

- Milvus version: master-20240520-555df49d-amd64
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2): go client v2.0.0-20240521081339-017fd7bc25de
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

create binary collection with invalid dim succ, and describe collection show that dim is 128

• case:

  func TestCreateBinaryCollectionInvalidDim(t *testing.T) {
  t.Parallel()
  type invalidDimStruct struct {
      dim    int64
      errMsg string
  }
  
  invalidDims := []invalidDimStruct{
      {dim: 10, errMsg: "should be multiple of 8"},
      {dim: 0, errMsg: "should be in range 2 ~ 32768"},
      {dim: 1, errMsg: "should be in range 2 ~ 32768"},
      {dim: common.MaxDim*9, errMsg: "binary vector dimension should be in range 2 ~ 262144"},
      {dim: common.MaxDim*8+1, errMsg: "binary vector dimension should be multiple of 8"},
  }
  
  ctx := createContext(t, time.Second*common.DefaultTimeout)
  mc := createDefaultMilvusClient(ctx, t)
  
  for _, invalidDim := range invalidDims {
      log.Debug("TestCreateBinaryCollectionInvalidDim", zap.Int64("dim", invalidDim.dim))
      collName := common.GenRandomString(prefix, 6)
      // field and schema have opposite autoID
      schema := entity.NewSchema().WithField(
          entity.NewField().WithName(common.DefaultInt64FieldName).WithDataType(entity.FieldTypeInt64).WithIsPrimaryKey(true)).WithField(
          entity.NewField().WithName(common.DefaultBinaryVecFieldName).WithDataType(entity.FieldTypeBinaryVector).WithDim(common.DefaultDim),
      ).WithName(collName)
  
      // create collection
      err := mc.CreateCollection(ctx, clientv2.NewCreateCollectionOption(collName, schema))
      //common.CheckErr(t, err, false, invalidDim.errMsg)
      common.CheckErr(t, err, true)
  
      coll, err := mc.DescribeCollection(ctx, clientv2.NewDescribeCollectionOption(collName))
      common.CheckErr(t, err, true)
      log.Info("coll", zap.String("field_dim", coll.Schema.Fields[1].TypeParams[entity.TypeParamDim]))
  }
  }

• log:

  [2024/05/21 17:55:56.067 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=NewClient] [args="[{\"Context\":0},{\"Address\":\"10.104.27.168:19530\",\"Username\":\"\",\"Password\":\"\",\"DBName\":\"\",\"EnableTLSAuth\":false,\"APIKey\":\"\",\"DialOptions\":null,\"RetryRateLimit\":null,\"DisableConn\":false,\"ServerVersion\":\"\"}]"]
  [2024/05/21 17:55:56.088 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=NewClient] [results="[{}]"]
  [2024/05/21 17:55:56.088 +08:00] [DEBUG] [testcases/collection_test.go:290] [TestCreateBinaryCollectionInvalidDim] [dim=10]
  [2024/05/21 17:55:56.088 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=CreateCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.101 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=CreateCollection] [results=null]
  [2024/05/21 17:55:56.101 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=DescribeCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.107 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=DescribeCollection] [results="[{\"ID\":449888564166886577,\"Name\":\"collection_YmERWs\",\"Schema\":{\"CollectionName\":\"collection_YmERWs\",\"Description\":\"\",\"AutoID\":false,\"Fields\":[{\"ID\":100,\"Name\":\"int64\",\"PrimaryKey\":true,\"AutoID\":false,\"Description\":\"\",\"DataType\":5,\"TypeParams\":{},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0},{\"ID\":101,\"Name\":\"binaryVec\",\"PrimaryKey\":false,\"AutoID\":false,\"Description\":\"\",\"DataType\":100,\"TypeParams\":{\"dim\":\"128\"},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0}],\"EnableDynamicField\":false},\"PhysicalChannels\":[\"by-dev-rootcoord-dml_10\"],\"VirtualChannels\":[\"by-dev-rootcoord-dml_10_449888564166886577v0\"],\"Loaded\":false,\"ConsistencyLevel\":2,\"ShardNum\":1,\"Properties\":{}}]"]
  [2024/05/21 17:55:56.107 +08:00] [INFO] [testcases/collection_test.go:305] [coll] [field_dim=128]
  [2024/05/21 17:55:56.107 +08:00] [DEBUG] [testcases/collection_test.go:290] [TestCreateBinaryCollectionInvalidDim] [dim=0]
  [2024/05/21 17:55:56.107 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=CreateCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.119 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=CreateCollection] [results=null]
  [2024/05/21 17:55:56.119 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=DescribeCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.125 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=DescribeCollection] [results="[{\"ID\":449888564166886584,\"Name\":\"collection_qpWIUh\",\"Schema\":{\"CollectionName\":\"collection_qpWIUh\",\"Description\":\"\",\"AutoID\":false,\"Fields\":[{\"ID\":100,\"Name\":\"int64\",\"PrimaryKey\":true,\"AutoID\":false,\"Description\":\"\",\"DataType\":5,\"TypeParams\":{},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0},{\"ID\":101,\"Name\":\"binaryVec\",\"PrimaryKey\":false,\"AutoID\":false,\"Description\":\"\",\"DataType\":100,\"TypeParams\":{\"dim\":\"128\"},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0}],\"EnableDynamicField\":false},\"PhysicalChannels\":[\"by-dev-rootcoord-dml_11\"],\"VirtualChannels\":[\"by-dev-rootcoord-dml_11_449888564166886584v0\"],\"Loaded\":false,\"ConsistencyLevel\":2,\"ShardNum\":1,\"Properties\":{}}]"]
  [2024/05/21 17:55:56.125 +08:00] [INFO] [testcases/collection_test.go:305] [coll] [field_dim=128]
  [2024/05/21 17:55:56.125 +08:00] [DEBUG] [testcases/collection_test.go:290] [TestCreateBinaryCollectionInvalidDim] [dim=1]
  [2024/05/21 17:55:56.125 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=CreateCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.138 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=CreateCollection] [results=null]
  [2024/05/21 17:55:56.138 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=DescribeCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.144 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=DescribeCollection] [results="[{\"ID\":449888564166886591,\"Name\":\"collection_bnfgGf\",\"Schema\":{\"CollectionName\":\"collection_bnfgGf\",\"Description\":\"\",\"AutoID\":false,\"Fields\":[{\"ID\":100,\"Name\":\"int64\",\"PrimaryKey\":true,\"AutoID\":false,\"Description\":\"\",\"DataType\":5,\"TypeParams\":{},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0},{\"ID\":101,\"Name\":\"binaryVec\",\"PrimaryKey\":false,\"AutoID\":false,\"Description\":\"\",\"DataType\":100,\"TypeParams\":{\"dim\":\"128\"},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0}],\"EnableDynamicField\":false},\"PhysicalChannels\":[\"by-dev-rootcoord-dml_12\"],\"VirtualChannels\":[\"by-dev-rootcoord-dml_12_449888564166886591v0\"],\"Loaded\":false,\"ConsistencyLevel\":2,\"ShardNum\":1,\"Properties\":{}}]"]
  [2024/05/21 17:55:56.144 +08:00] [INFO] [testcases/collection_test.go:305] [coll] [field_dim=128]
  [2024/05/21 17:55:56.144 +08:00] [DEBUG] [testcases/collection_test.go:290] [TestCreateBinaryCollectionInvalidDim] [dim=294912]
  [2024/05/21 17:55:56.144 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=CreateCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.157 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=CreateCollection] [results=null]
  [2024/05/21 17:55:56.157 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=DescribeCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.163 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=DescribeCollection] [results="[{\"ID\":449888564166886598,\"Name\":\"collection_fNmzha\",\"Schema\":{\"CollectionName\":\"collection_fNmzha\",\"Description\":\"\",\"AutoID\":false,\"Fields\":[{\"ID\":100,\"Name\":\"int64\",\"PrimaryKey\":true,\"AutoID\":false,\"Description\":\"\",\"DataType\":5,\"TypeParams\":{},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0},{\"ID\":101,\"Name\":\"binaryVec\",\"PrimaryKey\":false,\"AutoID\":false,\"Description\":\"\",\"DataType\":100,\"TypeParams\":{\"dim\":\"128\"},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0}],\"EnableDynamicField\":false},\"PhysicalChannels\":[\"by-dev-rootcoord-dml_13\"],\"VirtualChannels\":[\"by-dev-rootcoord-dml_13_449888564166886598v0\"],\"Loaded\":false,\"ConsistencyLevel\":2,\"ShardNum\":1,\"Properties\":{}}]"]
  [2024/05/21 17:55:56.163 +08:00] [INFO] [testcases/collection_test.go:305] [coll] [field_dim=128]
  [2024/05/21 17:55:56.163 +08:00] [DEBUG] [testcases/collection_test.go:290] [TestCreateBinaryCollectionInvalidDim] [dim=262145]
  [2024/05/21 17:55:56.163 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=CreateCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.177 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=CreateCollection] [results=null]
  [2024/05/21 17:55:56.177 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=DescribeCollection] [args="[{\"Context\":0},{},null]"]
  [2024/05/21 17:55:56.183 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=DescribeCollection] [results="[{\"ID\":449888564166886605,\"Name\":\"collection_pBKsii\",\"Schema\":{\"CollectionName\":\"collection_pBKsii\",\"Description\":\"\",\"AutoID\":false,\"Fields\":[{\"ID\":100,\"Name\":\"int64\",\"PrimaryKey\":true,\"AutoID\":false,\"Description\":\"\",\"DataType\":5,\"TypeParams\":{},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0},{\"ID\":101,\"Name\":\"binaryVec\",\"PrimaryKey\":false,\"AutoID\":false,\"Description\":\"\",\"DataType\":100,\"TypeParams\":{\"dim\":\"128\"},\"IndexParams\":{},\"IsDynamic\":false,\"IsPartitionKey\":false,\"ElementType\":0}],\"EnableDynamicField\":false},\"PhysicalChannels\":[\"by-dev-rootcoord-dml_14\"],\"VirtualChannels\":[\"by-dev-rootcoord-dml_14_449888564166886605v0\"],\"Loaded\":false,\"ConsistencyLevel\":2,\"ShardNum\":1,\"Properties\":{}}]"]
  [2024/05/21 17:55:56.183 +08:00] [INFO] [testcases/collection_test.go:305] [coll] [field_dim=128]
  [2024/05/21 17:55:56.183 +08:00] [INFO] [base/milvus_client.go:20] [ApiRequest] [func=Close] [args=null]
  [2024/05/21 17:55:56.183 +08:00] [INFO] [base/milvus_client.go:27] [ApiResponse] [func=Close] [results=null]

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

[congqixia]

the test code used common.DefaultDim which is valid

entity.NewField().WithName(common.DefaultBinaryVecFieldName).WithDataType(entity.FieldTypeBinaryVector).WithDim(common.DefaultDim),

[congqixia]

/unassign /assign @ThreadDao

[ThreadDao]

mistake