milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
29.37k stars 2.82k forks source link

[Bug]: Milvus build failure due to Proto resolution error #35560

Open ashkrisk opened 3 weeks ago

ashkrisk commented 3 weeks ago

Is there an existing issue for this?

Environment

- Milvus version: master branch
- Deployment mode(standalone or cluster): NA
- MQ type(rocksmq, pulsar or kafka): NA
- SDK version(e.g. pymilvus v2.0.0rc2): NA
- OS(Ubuntu or CentOS): CentOS
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Milvus build fails in the make generated-proto stage because of the following error:

root_coord.proto:127:20: "milvus.BackupRBACMetaRequest" is resolved to "milvus.proto.milvus.BackupRBACMetaRequest", which is not defined. The innermost scope is searched first in name resolution. Consider using a leading '.'(i.e., ".milvus.BackupRBACMetaRequest") to start from the outermost scope.

Expected Behavior

Milvus build should succeed.

Steps To Reproduce

1. Run `make`.
2. Observe that `make` fails in the `generated-proto` stage.

Milvus Log

$ make

[...]
install protoc-gen-go 1.33.0 to /workspaces/milvus/bin
install protoc-gen-go-grpc 1.3.0 to /workspaces/milvus/bin
Generate proto ...
using protoc-gen-go: /workspaces/milvus/bin/protoc-gen-go
using protoc-gen-go-grpc: /workspaces/milvus/bin/protoc-gen-go-grpc
/workspaces/milvus/internal/proto /workspaces/milvus
root_coord.proto:127:20: "milvus.BackupRBACMetaRequest" is resolved to "milvus.proto.milvus.BackupRBACMetaRequest", which is not defined. The innermost scope is searched first in name resolution. Consider using a leading '.'(i.e., ".milvus.BackupRBACMetaRequest") to start from the outermost scope.
root_coord.proto:127:59: "milvus.BackupRBACMetaResponse" is resolved to "milvus.proto.milvus.BackupRBACMetaResponse", which is not defined. The innermost scope is searched first in name resolution. Consider using a leading '.'(i.e., ".milvus.BackupRBACMetaResponse") to start from the outermost scope.
root_coord.proto:128:21: "milvus.RestoreRBACMetaRequest" is resolved to "milvus.proto.milvus.RestoreRBACMetaRequest", which is not defined. The innermost scope is searched first in name resolution. Consider using a leading '.'(i.e., ".milvus.RestoreRBACMetaRequest") to start from the outermost scope.
generate root_coord.proto failed
make: *** [Makefile:254: generated-proto] Error 1

Anything else?

No response

yanliang567 commented 3 weeks ago

/assign @yhmo did we update the proto recently? /unassign

xiaofan-luan commented 3 weeks ago

We have this updated 4 days ago.

xiaofan-luan commented 3 weeks ago

@weiliu1031 please take a look like