milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.49k stars 2.92k forks source link

[Bug]: milvus master branch cannot be compiled from the source #36639

Open alexanderguzhva opened 1 month ago

alexanderguzhva commented 1 month ago

Is there an existing issue for this?

Environment

- Milvus version:
master branch (2.4.12+, 3936d126614de6cefe52b9d061ef4007cd94ae3c)
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
ubuntu 22.04 LTS
- CPU/Memory: 
- GPU: 
- Others: 
Rust 1.81.0

Current Behavior

milvus cannot be compiled if cloned from github and run make

I understand that we're using Rust 1.73.0 for the compilation, but the outdated components start to be concerning...

Expected Behavior

everything compiles

Steps To Reproduce

* git clone https://github.com/milvus-io/milvus
* install prereqs
* install rust via `curl --proto '=https' --tlsv1.3 https://sh.rustup.rs -sSf | sh`, as recommended. Rust 1.81.0 will be installed.
* run `make` in the root directory of milvus sources 

The following error appears:

error[E0282]: type annotations needed for `Box<_>`
  --> /home/ubuntu/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update`

error: could not compile `time` (lib) due to 1 previous error

and the compilation fails



### Milvus Log

_No response_

### Anything else?

_No response_
xiaofan-luan commented 1 month ago

can it work by changing cargo.lock dependency from 0.3.34 to 0.3.36?

alexanderguzhva commented 1 month ago

my point was that we're not keeping up with the most recent versions

yanliang567 commented 1 month ago

/assign @Presburger please help to take a look

/unassign