milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.53k stars 2.92k forks source link

[Bug]: Error Msg is meaningless #37543

Open yanliang567 opened 1 week ago

yanliang567 commented 1 week ago

Is there an existing issue for this?

Environment

- Milvus version: master-20241108-bc9562fe-amd64
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2): 2.5.0rc114

Current Behavior

  1. create a vector field with invalid dim, e.g. 32.1, returns msg: message=strconv.ParseInt: parsing "32.1": invalid syntax

Expected Behavior

return a meaningful error msg

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

yanliang567 commented 1 week ago

More meaningless error will be added into this issue.

yanliang567 commented 1 week ago

in test_create_scalar_index_on_binary_vector_field, when you create index with invalid params, it returns: (code=1100, message=metric type not set for vector index: invalid parameter[expected=valid index params][actual=invalid index params])> expected and actual in the msg are meaningless.

yanliang567 commented 1 week ago

in test_bitmap_on_not_supported_fields, when you trying to create bitmap index on float field, it returns: bitmap index are only supported on bool, int, string for array field expected msg: bitmap index are only supported on bool, int, string and array field

yanliang567 commented 1 week ago

in test_query_invalid, when trying to filter with a non existing function, it returns: 65535 fail to Query on QueryNode 1: worker(1) query failed: => function a_function_that_does_not_exist() not found. at /workspace/source/internal/core/src/query/PlanProto.cpp:277 expected: no trace, just meaningful msg

yanliang567 commented 1 week ago

in test test_search_with_empty_collection when trying to search without collection loaded, it returns: 101 failed to search: collection not loaded[collection=453783719580683582] expected: "collection was not loaded" something like that with name instead of id

yanliang567 commented 1 week ago

in test test_search_dynamic_compare_two_fields when trying to comparing two field in expr, it returns: 65535 fail to search on QueryNode 1: worker(1) query failed: Operator::GetOutput failed for [Operator:PhyFilterBitsNode, plan node id: 6377] : => unsupported left datatype:JSON of compare expr at /workspace/source/internal/core/src/exec/expression/CompareExpr.cpp:203 expected: "comparing two field value is not supported" something like that

yanliang567 commented 1 week ago

/assign @liliu-z /unassign

yanliang567 commented 4 days ago

in test_delete_expr_none, when trying to delete with expr=None, it returns: code=1, message=None cannot be None expected: msg could be expr cannot be None

yanliang567 commented 4 days ago

in test_insert_dim_not_match, when trying to insert dataframe data with dim dismatched with schema, it returns: the length(2580) of float data should divide the dim(128) expected msg: the dim of field data is not equal to schema idm, something like that.

yanliang567 commented 4 days ago

in test_search_invalid_params_type when trying to search with invalid params, it returns res = Error(code=65535, message=fail to search on QueryNode 1: worker(1) query failed: Operator::GetOutput failed for [Opera...e' (9999999999) should not bigger than 2147483647 at /workspace/source/internal/core/src/index/VectorMemIndex.cpp:411 expected: a meaningful msg with which value is out of range, what is the valid range, without trace,

yanliang567 commented 2 days ago

in test_milvus_client_collection_invalid_dim, if create collection with min_dim-1, it returns res = Error(code=65535, message=invalid dimension: 32769. should be in range 2 ~ 32768), actual = False while if creating collection with max_dim+1, it returns res = Error(code=65535, message=invalid dimension: 32769. float vector dimension should be in range 2 ~ 32768), actual = False Shall we just make these 2 error messages that same?