search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.87k stars 2.94k forks source link

enhance: Add thread watcher to provide actual thread num #37905

Closed congqixia closed 12 hours ago

congqixia commented 1 day ago

Related to #37904

mergify[bot] commented 1 day ago

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 1 day ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 1 day ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

congqixia commented 1 day ago

/run-cpu-e2e

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 2.70270% with 36 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (70e6a00) to head (2804f39). Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/metrics/thread.go 0.00% 36 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37905/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37905?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37905 +/- ## ======================================= Coverage 81.04% 81.04% ======================================= Files 1357 1358 +1 Lines 190143 190232 +89 ======================================= + Hits 154095 154173 +78 - Misses 30584 30602 +18 + Partials 5464 5457 -7 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37905/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.16% <ø> (ø)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37905/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.21% <2.63%> (+<0.01%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37905?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [pkg/metrics/info\_metrics.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37905?src=pr&el=tree&filepath=pkg%2Fmetrics%2Finfo_metrics.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-cGtnL21ldHJpY3MvaW5mb19tZXRyaWNzLmdv) | `100.00% <ø> (ø)` | | | [pkg/metrics/metrics.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37905?src=pr&el=tree&filepath=pkg%2Fmetrics%2Fmetrics.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-cGtnL21ldHJpY3MvbWV0cmljcy5nbw==) | `100.00% <100.00%> (ø)` | | | [internal/util/metrics/thread.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37905?src=pr&el=tree&filepath=internal%2Futil%2Fmetrics%2Fthread.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvdXRpbC9tZXRyaWNzL3RocmVhZC5nbw==) | `0.00% <0.00%> (ø)` | | ... and [36 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37905/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features:

sre-ci-robot commented 12 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, LoveEachDay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/milvus-io/milvus/blob/master/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment