milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.87k stars 2.94k forks source link

enhance: Refine Replica manager colle2Replicas secondary index #37906

Closed congqixia closed 11 hours ago

congqixia commented 1 day ago

Related to #37630

This PR add a new util coll2Replicas secondary index to reduce map access & iteration while get replicas by collection

sre-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/querycoordv2/meta/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/querycoordv2/meta/OWNERS)~~ [congqixia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 1 day ago

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify[bot] commented 1 day ago

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify[bot] commented 1 day ago

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

congqixia commented 1 day ago

rerun go-sdk

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (70e6a00) to head (c4f1b83). Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/meta/replica_manager.go 90.47% 3 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37906/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37906?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37906 +/- ## ========================================== + Coverage 81.04% 81.06% +0.02% ========================================== Files 1357 1357 Lines 190143 190202 +59 ========================================== + Hits 154095 154189 +94 + Misses 30584 30554 -30 + Partials 5464 5459 -5 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37906/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37906/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.16% <ø> (ø)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37906/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37906/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.24% <88.37%> (+0.02%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37906?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querycoordv2/meta/replica\_manager.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37906?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fmeta%2Freplica_manager.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL21ldGEvcmVwbGljYV9tYW5hZ2VyLmdv) | `81.37% <90.47%> (+0.38%)` | :arrow_up: | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37906/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features:

weiliu1031 commented 11 hours ago

/lgtm