milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.87k stars 2.94k forks source link

fix: unstable integration test caused by paramtable.GetNodeID #37909

Closed weiliu1031 closed 1 day ago

weiliu1031 commented 1 day ago

issue: #37908 cause paramtable is global single instance, which cause paramtable.GetNodeID may return wrong server id in integration test.

This PR use node.GetNodeID to replace paramtable.GetNodeID

czs007 commented 1 day ago

/approve

sre-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/querynodev2/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/querynodev2/OWNERS)~~ [congqixia,czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
weiliu1031 commented 1 day ago

this PR will also fix the issue which delegator has dirty view, cause by delegator set the wrong target node id to distribution based on the fix #37748 image

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (b983ef9) to head (d4f599c). Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/services.go 33.33% 3 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37909/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37909 +/- ## ========================================== - Coverage 81.03% 81.01% -0.03% ========================================== Files 1357 1357 Lines 190182 190192 +10 ========================================== - Hits 154121 154091 -30 - Misses 30591 30614 +23 - Partials 5470 5487 +17 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37909/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37909/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.16% <ø> (ø)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37909/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37909/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.19% <33.33%> (-0.03%)` | :arrow_down: | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37909?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querynodev2/delegator/delegator\_data.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37909?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fdelegator%2Fdelegator_data.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvZGVsZWdhdG9yL2RlbGVnYXRvcl9kYXRhLmdv) | `85.39% <ø> (-0.49%)` | :arrow_down: | | [internal/querynodev2/services.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37909?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fservices.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VydmljZXMuZ28=) | `87.15% <33.33%> (-0.27%)` | :arrow_down: | ... and [29 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37909/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features:

weiliu1031 commented 1 day ago

rerun ut