Closed weiliu1031 closed 1 day ago
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: congqixia, czs007, weiliu1031
The full list of commands accepted by this bot can be found here.
The pull request process is described here
this PR will also fix the issue which delegator has dirty view, cause by delegator set the wrong target node id to distribution based on the fix #37748
Attention: Patch coverage is 33.33333%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 81.01%. Comparing base (
b983ef9
) to head (d4f599c
). Report is 12 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
internal/querynodev2/services.go | 33.33% | 3 Missing and 1 partial :warning: |
🚨 Try these New Features:
rerun ut
issue: #37908 cause paramtable is global single instance, which cause paramtable.GetNodeID may return wrong server id in integration test.
This PR use node.GetNodeID to replace paramtable.GetNodeID