Closed weiliu1031 closed 12 hours ago
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: congqixia, czs007, weiliu1031
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Attention: Patch coverage is 33.33333%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 80.59%. Comparing base (
0bd2617
) to head (6436e14
). Report is 1 commits behind head on 2.4.
Files with missing lines | Patch % | Lines |
---|---|---|
internal/querynodev2/services.go | 33.33% | 3 Missing and 1 partial :warning: |
🚨 Try these New Features:
issue: #37908 pr: #37909 cause paramtable is global single instance, which cause paramtable.GetNodeID may return wrong server id in integration test.
This PR use node.GetNodeID to replace paramtable.GetNodeID