milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.87k stars 2.94k forks source link

fix: unstable integration test caused by paramtable.GetNodeID #37910

Closed weiliu1031 closed 12 hours ago

weiliu1031 commented 1 day ago

issue: #37908 pr: #37909 cause paramtable is global single instance, which cause paramtable.GetNodeID may return wrong server id in integration test.

This PR use node.GetNodeID to replace paramtable.GetNodeID

czs007 commented 1 day ago

/approve

sre-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/querynodev2/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/internal/querynodev2/OWNERS)~~ [congqixia,czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.59%. Comparing base (0bd2617) to head (6436e14). Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querynodev2/services.go 33.33% 3 Missing and 1 partial :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37910/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #37910 +/- ## ========================================== - Coverage 80.63% 80.59% -0.04% ========================================== Files 1069 1069 Lines 166978 166979 +1 ========================================== - Hits 134643 134579 -64 - Misses 27930 27979 +49 - Partials 4405 4421 +16 ``` | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37910?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querynodev2/delegator/delegator\_data.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37910?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fdelegator%2Fdelegator_data.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvZGVsZWdhdG9yL2RlbGVnYXRvcl9kYXRhLmdv) | `88.47% <ø> (-0.09%)` | :arrow_down: | | [internal/querynodev2/services.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37910?src=pr&el=tree&filepath=internal%2Fquerynodev2%2Fservices.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnlub2RldjIvc2VydmljZXMuZ28=) | `86.54% <33.33%> (-0.65%)` | :arrow_down: | ... and [34 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37910/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features: