search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.87k stars 2.94k forks source link

enhance: refine querycoord meta/catalog related interfaces to ensure that each method includes a ctx parameter #37916

Open tinswzy opened 1 day ago

tinswzy commented 1 day ago

issue: #35917 This PR refine the querycoord meta related interfaces to ensure that each method includes a ctx parameter.

sre-ci-robot commented 1 day ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tinswzy To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed. You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mergify[bot] commented 23 hours ago

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

tinswzy commented 23 hours ago

rerun go-sdk

codecov[bot] commented 23 hours ago

Codecov Report

Attention: Patch coverage is 92.92035% with 40 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (3cb9511) to head (976f961). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ernal/querycoordv2/balance/multi_target_balance.go 0.00% 7 Missing :warning:
internal/querycoordv2/meta/resource_manager.go 86.00% 2 Missing and 5 partials :warning:
internal/querycoordv2/job/job_update.go 60.00% 2 Missing and 2 partials :warning:
...rnal/querycoordv2/observers/collection_observer.go 84.00% 4 Missing :warning:
internal/querycoordv2/utils/meta.go 81.81% 2 Missing and 2 partials :warning:
internal/querycoordv2/meta/replica_manager.go 90.32% 1 Missing and 2 partials :warning:
internal/querycoordv2/server.go 84.21% 3 Missing :warning:
internal/querycoordv2/balance/balance.go 66.66% 1 Missing :warning:
...erycoordv2/balance/channel_level_score_balancer.go 94.11% 1 Missing :warning:
internal/querycoordv2/job/job_sync.go 66.66% 0 Missing and 1 partial :warning:
... and 5 more
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37916/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37916 +/- ## ========================================== + Coverage 81.02% 81.05% +0.02% ========================================== Files 1357 1357 Lines 190195 190394 +199 ========================================== + Hits 154113 154322 +209 + Misses 30601 30595 -6 + Partials 5481 5477 -4 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37916/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37916/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.16% <ø> (ø)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37916/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.23% <92.92%> (+0.02%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/metastore/catalog.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fmetastore%2Fcatalog.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvbWV0YXN0b3JlL2NhdGFsb2cuZ28=) | `100.00% <ø> (ø)` | | | [internal/metastore/kv/querycoord/kv\_catalog.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fmetastore%2Fkv%2Fquerycoord%2Fkv_catalog.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvbWV0YXN0b3JlL2t2L3F1ZXJ5Y29vcmQva3ZfY2F0YWxvZy5nbw==) | `65.31% <100.00%> (ø)` | | | [...al/querycoordv2/balance/rowcount\_based\_balancer.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fbalance%2Frowcount_based_balancer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2JhbGFuY2Uvcm93Y291bnRfYmFzZWRfYmFsYW5jZXIuZ28=) | `95.08% <100.00%> (ø)` | | | [...ernal/querycoordv2/balance/score\_based\_balancer.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fbalance%2Fscore_based_balancer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2JhbGFuY2Uvc2NvcmVfYmFzZWRfYmFsYW5jZXIuZ28=) | `98.97% <100.00%> (+1.70%)` | :arrow_up: | | [internal/querycoordv2/checkers/balance\_checker.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fcheckers%2Fbalance_checker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2NoZWNrZXJzL2JhbGFuY2VfY2hlY2tlci5nbw==) | `95.95% <100.00%> (ø)` | | | [internal/querycoordv2/checkers/channel\_checker.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fcheckers%2Fchannel_checker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2NoZWNrZXJzL2NoYW5uZWxfY2hlY2tlci5nbw==) | `85.38% <100.00%> (-1.76%)` | :arrow_down: | | [internal/querycoordv2/checkers/index\_checker.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fcheckers%2Findex_checker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2NoZWNrZXJzL2luZGV4X2NoZWNrZXIuZ28=) | `79.09% <100.00%> (ø)` | | | [internal/querycoordv2/checkers/leader\_checker.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fcheckers%2Fleader_checker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2NoZWNrZXJzL2xlYWRlcl9jaGVja2VyLmdv) | `96.89% <100.00%> (ø)` | | | [internal/querycoordv2/checkers/segment\_checker.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fcheckers%2Fsegment_checker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2NoZWNrZXJzL3NlZ21lbnRfY2hlY2tlci5nbw==) | `90.79% <100.00%> (-0.93%)` | :arrow_down: | | [internal/querycoordv2/dist/dist\_controller.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fdist%2Fdist_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2Rpc3QvZGlzdF9jb250cm9sbGVyLmdv) | `85.71% <100.00%> (ø)` | | | ... and [26 more](https://app.codecov.io/gh/milvus-io/milvus/pull/37916?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | | ... and [32 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37916/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features: