search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.87k stars 2.94k forks source link

fix: add ddl and dcl concurrency to avoid competition #37923

Open chyezh opened 11 hours ago

chyezh commented 11 hours ago

issue: #37166 pr: #37672

sre-ci-robot commented 11 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh To complete the pull request process, please assign czs007 after the PR has been reviewed. You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[configs/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/configs/OWNERS)** - **[internal/proxy/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/internal/proxy/OWNERS)** - **[pkg/util/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/pkg/util/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bigsheeper commented 11 hours ago

/hold 2.4.18

codecov[bot] commented 9 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.66%. Comparing base (e63a2f3) to head (bfab668). Report is 1 commits behind head on 2.4.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37923/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37923?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #37923 +/- ## ========================================== + Coverage 79.70% 80.66% +0.95% ========================================== Files 1069 1069 Lines 166979 167005 +26 ========================================== + Hits 133092 134708 +1616 + Misses 29490 27901 -1589 + Partials 4397 4396 -1 ``` | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37923?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/proxy/task\_scheduler.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37923?src=pr&el=tree&filepath=internal%2Fproxy%2Ftask_scheduler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcHJveHkvdGFza19zY2hlZHVsZXIuZ28=) | `94.69% <100.00%> (+0.11%)` | :arrow_up: | | [pkg/util/paramtable/component\_param.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37923?src=pr&el=tree&filepath=pkg%2Futil%2Fparamtable%2Fcomponent_param.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-cGtnL3V0aWwvcGFyYW10YWJsZS9jb21wb25lbnRfcGFyYW0uZ28=) | `98.36% <100.00%> (+<0.01%)` | :arrow_up: | ... and [102 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37923/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features: