search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.87k stars 2.94k forks source link

fix: Prevent simultaneous balance of segments and channels (#37850) #37939

Open weiliu1031 opened 6 hours ago

weiliu1031 commented 6 hours ago

issue: #33550 pr: #37850 balance segment and balance segment execute at same time, which will cause bounch of corner case.

This PR disable simultaneous balance of segments and channels

sre-ci-robot commented 6 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031 To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed. You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[configs/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/configs/OWNERS)** - **[internal/querycoordv2/balance/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/internal/querycoordv2/balance/OWNERS)** - **[internal/querycoordv2/task/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/internal/querycoordv2/task/OWNERS)** - **[pkg/util/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/pkg/util/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 hours ago

Codecov Report

Attention: Patch coverage is 77.27273% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (fc96133) to head (959f2a3). Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querycoordv2/task/scheduler.go 76.31% 6 Missing and 3 partials :warning:
...ernal/querycoordv2/balance/multi_target_balance.go 0.00% 6 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37939/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37939?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #37939 +/- ## ========================================== - Coverage 80.62% 79.67% -0.95% ========================================== Files 1069 1069 Lines 166979 167025 +46 ========================================== - Hits 134621 133083 -1538 - Misses 27946 29520 +1574 - Partials 4412 4422 +10 ``` | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37939?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querycoordv2/balance/balance.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37939?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fbalance%2Fbalance.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2JhbGFuY2UvYmFsYW5jZS5nbw==) | `94.11% <100.00%> (+0.29%)` | :arrow_up: | | [...erycoordv2/balance/channel\_level\_score\_balancer.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37939?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fbalance%2Fchannel_level_score_balancer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2JhbGFuY2UvY2hhbm5lbF9sZXZlbF9zY29yZV9iYWxhbmNlci5nbw==) | `90.39% <100.00%> (+0.68%)` | :arrow_up: | | [...al/querycoordv2/balance/rowcount\_based\_balancer.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37939?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fbalance%2Frowcount_based_balancer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2JhbGFuY2Uvcm93Y291bnRfYmFzZWRfYmFsYW5jZXIuZ28=) | `95.08% <100.00%> (+0.03%)` | :arrow_up: | | [...ernal/querycoordv2/balance/score\_based\_balancer.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37939?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fbalance%2Fscore_based_balancer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2JhbGFuY2Uvc2NvcmVfYmFzZWRfYmFsYW5jZXIuZ28=) | `98.96% <100.00%> (+1.74%)` | :arrow_up: | | [...ernal/querycoordv2/balance/multi\_target\_balance.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37939?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fbalance%2Fmulti_target_balance.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2JhbGFuY2UvbXVsdGlfdGFyZ2V0X2JhbGFuY2UuZ28=) | `83.20% <0.00%> (-0.42%)` | :arrow_down: | | [internal/querycoordv2/task/scheduler.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37939?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Ftask%2Fscheduler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL3Rhc2svc2NoZWR1bGVyLmdv) | `90.00% <76.31%> (+1.06%)` | :arrow_up: | ... and [98 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37939/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features: