milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.87k stars 2.94k forks source link

fix: Channel may be released after balance (#37862) #37940

Open weiliu1031 opened 6 hours ago

weiliu1031 commented 6 hours ago

issue: #37830 pr: #37862 casue dist handler doesn't set channel's version, so if channel checker try to dedup channel, it may release the new delegator after balance finished.

this PR fix the way to set proper version for channel.

sre-ci-robot commented 6 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031 To complete the pull request process, please assign yanliang567 after the PR has been reviewed. You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[internal/querycoordv2/dist/OWNERS](https://github.com/milvus-io/milvus/blob/2.4/internal/querycoordv2/dist/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 5 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.67%. Comparing base (fc96133) to head (d421c4f). Report is 1 commits behind head on 2.4.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37940/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #37940 +/- ## ========================================== + Coverage 80.62% 83.67% +3.05% ========================================== Files 1069 801 -268 Lines 166979 140519 -26460 ========================================== - Hits 134621 117579 -17042 + Misses 27946 18524 -9422 - Partials 4412 4416 +4 ``` | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37940?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/querycoordv2/dist/dist\_handler.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37940?src=pr&el=tree&filepath=internal%2Fquerycoordv2%2Fdist%2Fdist_handler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvcXVlcnljb29yZHYyL2Rpc3QvZGlzdF9oYW5kbGVyLmdv) | `96.01% <100.00%> (+0.07%)` | :arrow_up: | ... and [300 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37940/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features: