milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.87k stars 2.94k forks source link

enhance: Remove unnecessary stack trace in error (#37816) #37941

Open weiliu1031 opened 6 hours ago

weiliu1031 commented 6 hours ago

pr: #37816

sre-ci-robot commented 6 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031 To complete the pull request process, please assign congqixia after the PR has been reviewed. You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/milvus-io/milvus/blob/2.4/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 hours ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.68%. Comparing base (fc96133) to head (bfa53b5). Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/util/mock/grpcclient.go 0.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37941/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## 2.4 #37941 +/- ## ========================================== + Coverage 80.62% 83.68% +3.06% ========================================== Files 1069 801 -268 Lines 166979 140514 -26465 ========================================== - Hits 134621 117586 -17035 + Misses 27946 18509 -9437 - Partials 4412 4419 +7 ``` | [Files with missing lines](https://app.codecov.io/gh/milvus-io/milvus/pull/37941?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [internal/util/mock/grpcclient.go](https://app.codecov.io/gh/milvus-io/milvus/pull/37941?src=pr&el=tree&filepath=internal%2Futil%2Fmock%2Fgrpcclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io#diff-aW50ZXJuYWwvdXRpbC9tb2NrL2dycGNjbGllbnQuZ28=) | `60.91% <0.00%> (+0.69%)` | :arrow_up: | ... and [297 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37941/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features: