milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
30.94k stars 2.95k forks source link

enhance: make all index operation async scheduled by tokio #37946

Closed chyezh closed 21 hours ago

chyezh commented 3 days ago

issue: #37851 related pr: https://github.com/milvus-io/tantivy/pull/3

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.01%. Comparing base (7bbfe86) to head (3547a4f). Report is 13 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/milvus-io/milvus/pull/37946/graphs/tree.svg?width=650&height=150&src=pr&token=XdCbzGJk2E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)](https://app.codecov.io/gh/milvus-io/milvus/pull/37946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) ```diff @@ Coverage Diff @@ ## master #37946 +/- ## =========================================== + Coverage 68.87% 81.01% +12.13% =========================================== Files 289 1358 +1069 Lines 25481 190558 +165077 =========================================== + Hits 17551 154375 +136824 - Misses 7930 30689 +22759 - Partials 0 5494 +5494 ``` | [Components](https://app.codecov.io/gh/milvus-io/milvus/pull/37946/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | Coverage Δ | | |---|---|---| | [Client](https://app.codecov.io/gh/milvus-io/milvus/pull/37946/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `72.16% <ø> (∅)` | | | [Core](https://app.codecov.io/gh/milvus-io/milvus/pull/37946/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `68.87% <ø> (ø)` | | | [Go](https://app.codecov.io/gh/milvus-io/milvus/pull/37946/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io) | `83.17% <ø> (∅)` | | [see 1069 files with indirect coverage changes](https://app.codecov.io/gh/milvus-io/milvus/pull/37946/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=milvus-io)

🚨 Try these New Features:

czs007 commented 21 hours ago

/approve /lgtm

sre-ci-robot commented 21 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[internal/core/OWNERS](https://github.com/milvus-io/milvus/blob/master/internal/core/OWNERS)~~ [czs007] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment