milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
29.59k stars 2.84k forks source link

restful api "/collections/{collection_name}/partitions (DELETE)" didn't work #4536

Closed bitxinyu closed 3 years ago

bitxinyu commented 3 years ago

Please state your issue using the following template and, most importantly, in English.

Describe the bug restful api "/collections/{collection_name}/partitions (DELETE)" didn't work. and response code is 404

Steps/Code to reproduce behavior The code for each step is copied from here https://github.com/milvus-io/milvus/tree/0.11.0/core/src/server/web_impl

  1. create a collection image
  2. create a partition in collection image
  3. check this partition image 4.delete this partition, I got a 404 error image

Expected behavior In restful api document, The deletion is successful if no information is returned.

Method of installation

Environment details

Configuration file use default milvus.yaml, but meta_url is a mysql database,

fishpenguin commented 3 years ago

The is a doc bug, in milvus-0.11.0, we change this api to "/collections/{collection_name}/partitions/{partition_tag} (DELETE)", but the doc has not updated. We will update the doc in milvus-0.11.1

bitxinyu commented 3 years ago

The is a doc bug, in milvus-0.11.0, we change this api to "/collections/{collection_name}/partitions/{partition_tag} (DELETE)", but the doc has not updated. We will update the doc in milvus-0.11.1

I see. I have tested all the restfull api. and found many bugs in document. :rofl: Thanks for your work.

fishpenguin commented 3 years ago

Yes, we didnot check the restful api doc carefully when 0.11.0 released. And we will fix these doc bugs in 0.11.1

fishpenguin commented 3 years ago

Fixed.