search

milvus-io / milvus

A cloud-native vector database, storage for next generation AI applications
https://milvus.io
Apache License 2.0
29.59k stars 2.84k forks source link

milvus-em use domian name to connect milvus without requiring both the host and port #4643

Closed bitxinyu closed 3 years ago

bitxinyu commented 3 years ago

Is your feature request related to a problem? Please describe. we use k8s to manage web services. The addresses of many web services are appended to a common path. eg. milvus restful api has been mapping to http://dev.company.com/milvus-service-restful but milvus-em requiring both the host and port to connect milvus. I wish I could connect to the service with only the domain name.

set host:http://dev.company.com/milvus-service-restful and port: 80 orport:19121 didn't work milvus v0.10.5 milvus-em v0.4.1

shanghaikid commented 3 years ago

@bitxinyu can you access http://dev.company.com/milvus-service-restful/state from your browser ?

bitxinyu commented 3 years ago

@bitxinyu can you access http://dev.company.com/milvus-service-restful/state from your browser ?

yes, of course. I have tested all the restfull api, and they all work. 2021-01-25_10-21

when I use milvus-em to connect milvus, port just be appended to http://dev.company.com/milvus-service-restful 2021-01-25_10-26

nameczz commented 3 years ago

@bitxinyu can you access http://dev.company.com/milvus-service-restful/state from your browser ?

yes, of course. I have tested all the restfull api, and they all work. 2021-01-25_10-21

when I use milvus-em to connect milvus, port just be appended to http://dev.company.com/milvus-service-restful 2021-01-25_10-26

For now, we always add port after host to call restful api. Host: http://dev.company.com/milvus-service-restful. Port: 19121 Restful Api: http://dev.company.com/milvus-service-restful:19121/state is working correct?

bitxinyu commented 3 years ago

@nameczz For now, we always add port after host to call restful api. Host: http://dev.company.com/milvus-service-restful. Port: 19121 Restful Api: http://dev.company.com/milvus-service-restful:19121/state is working correct?

Looks like something is wrong. here is result of port 19121 and port 80 . 2021-01-25_12-19_1 2021-01-25_12-20

and without port 2021-01-25_12-19

in my opinion, port 19121 has been mapping to http://dev.company.com/milvus-service-restful, We should not add the port number after the new address,the port number is redundant.

nameczz commented 3 years ago

@bitxinyu Yeah, i agree with that. But we need separate host and port in v0.4.1 and we will change it in next release.

bitxinyu commented 3 years ago

Great ! Thanks for your work, I'm looking forward to the next version.

nameczz commented 3 years ago

Great ! Thanks for your work, I'm looking forward to the next version.

We released v0.4.2 milvus-em and you can have a try. Thanks for your suggestion and any more advices is welcome!

bitxinyu commented 3 years ago

Great ! Thanks for your work, I'm looking forward to the next version.

We released v0.4.2 milvus-em and you can have a try. Thanks for your suggestion and any more advices is welcome!

why milvus-em v0.4.2 need port and milvus port ? UI of v0.4.2 looks like v0.5.0. and both port and milvus port should be given. the size of milvus-em v0.4.2 much larger than v0.4.1. image

nameczz commented 3 years ago

why milvus-em v0.4.2 need port and milvus port ? UI of v0.4.2 looks like v0.5.0. and both port and milvus port should be given. the size of milvus-em v0.4.2 much larger than v0.4.1. image

Sorry for that, my cicd program has some problem, now i fixed it and released v0.4.2 again.

bitxinyu commented 3 years ago

@nameczz Thanks for your work! Upgrade to the latest version and everything works fine .

shengjun1985 commented 3 years ago

Thanks all.