search

mindstellar / Osclass

With Osclass, get your own classifieds site for free. Build your own Osclass installation and start advertising real estate, jobs or whatever you want- in minutes!
https://docs.mindstellar.com/
GNU General Public License v3.0
89 stars 47 forks source link

Add functionality of popular basic plugins in core #211

Open patriksh opened 4 years ago

patriksh commented 4 years ago

These plugins don't need frequent updates or don't need updates at all, they're lightweight and essential.

They should be integrated in the core.

More plugin suggestions welcome.

Related: https://github.com/mindstellar/Osclass/issues/197

eurobank commented 4 years ago

Well RichEdit is so old, like something of 5 years back version of TinyMCE.

Also it seems there are TWO versions of TinyMCE, i wonder why. One for the admin and one as a plugin. Could that be only one?

patriksh commented 4 years ago

Well RichEdit is so old, like something of 5 years back version of TinyMCE.

Also it seems there are TWO versions of TinyMCE, i wonder why. One for the admin and one as a plugin. Could that be only one?

I'll update the admin version if needed and use it for frontend as well.

eurobank commented 4 years ago

@webmods-croatia

Keep in mind that i do remember an old topic from the Osclass forum(God rest his soul), @dev101 had said that you can't properly intergrate any editor. And the rich edit plugin was actually a hack.

I'm not a dev and i have no idea what was the meaning of that. Just saying.

patriksh commented 4 years ago

@webmods-croatia

Keep in mind that i do remember an old topic from the Osclass forum(God rest his soul), @dev101 had said that you can't properly intergrate any editor. And the rich edit plugin was actually a hack.

I'm not a dev and i have no idea what was the meaning of that. Just saying.

Saving the item description was a hack indeed, but no need for that when we can modify any core file we need to.

262925 commented 4 years ago

1.I recommend CKEditor instead of Rich Edit plugin.

  1. Google map is good but now a days google asking billing method. And Are you sure normal user will ready to provide their card information to google for just google map?
patriksh commented 4 years ago

1.I recommend CKEditor instead of Rich Edit plugin.

  1. Google map is good but now a days google asking billing method. And Are you sure normal user will ready to provide their card information to google for just google map?
  1. Thanks for the suggestion, I'll check it.
  2. I completely forgot about it, I just added my card info and I never get billed because I don't pass the limit... Maybe we should include both Open Street Maps and Google Maps.
navjottomer commented 4 years ago

For maps, it's better to only include geocoding from Open Street Maps( with a filter to override it to implement 3rd party provider ) and leave map implementation on themes and plugins. There is no need to include the whole plugin into osclass core

patriksh commented 4 years ago

For maps, it's better to only include geocoding from Open Street Maps( with a filter to override it to implement 3rd party provider ) and leave map implementation on themes and plugins. There is no need to include the whole plugin into osclass core

Ok, but I would still make a helper to show the map (Open Street Maps/Google) that can be used in admin and in themes.

arcsales commented 4 years ago

Proper listing moderation. Extend categories to support special categories like Jobs, Cars etc. For example you have to hide the price fields in Jobs category and regarding cars... you should be able to predefine car makes and car models. I have some old plugins for cars and edited them to suite some of my other categories like mobile phones where you also need nested custom fields. Build in bumpup, promotional and Top listings options with basic paypal acceptance.

patriksh commented 2 years ago

@navjottomer Working on GDPR + Cookie notice at the moment.

Should I add the GDPR checkboxes and the cookie modal as a part of the core, or just make helpers which should be used by themes?

I will need to add an extra column to the user table, what do I need to do to make it work when upgrading from previous versions? Same question but for mail templates, I'll need one of those as well.