search

mindstellar / Osclass

With Osclass, get your own classifieds site for free. Build your own Osclass installation and start advertising real estate, jobs or whatever you want- in minutes!
https://docs.mindstellar.com/
GNU General Public License v3.0
88 stars 49 forks source link

FineUploader 3.8.0 to latest or some other uploader script #25

Open patriksh opened 5 years ago

patriksh commented 5 years ago

Latest Fine Uploader could be either updated to the latest version 5.x or changed to some other script, as it reached it's end-of-life one year ago.

oc-includes/osclass/assets/js/fineuploader/jquery.fineuploader.min.js

dimalif commented 5 years ago

Well if updating to the latest (dead) version will NOT require theme changes, then go for it.

If 5.x update requires themes to be updated, then do not update FineUploader, just go for a new and modern script (i have no idea what that is).

patriksh commented 5 years ago

I was thinking of something like uppy.io. Looking at Bender code, image uploader is called like this:

<?php if( osc_images_enabled_at_items() ) { ItemForm::ajax_photos(); } ?>

That means that uploader code is in Osclass core. Theme edits probably won't be required.

mkraha commented 5 years ago

How about this uploader? https://github.com/pqina/filepond And consider this https://github.com/blueimp/jQuery-File-Upload/

patriksh commented 5 years ago

I used Filepond on a project, until I discovered that it's "extension" Doka is paid... Doka had just what I needed (rotate/crop/resize) but I needed a free solution.

mkraha commented 5 years ago

But what i thought, we just need a good and modern uploader before move to big.

patriksh commented 5 years ago

Let's see what @navjottomer thinks. They're all good. Rotate feature would be a nice addition to uploader.

patriksh commented 4 years ago

@navjottomer What are your thoughts about using uppy.io and tus.io for Osclass image uploading? I've been thinking to include them in my theme and get rid of Fine Uploader, but if we would do it on the new Osclass version I wouldn't need to "struggle" with implementing it as much.

Closed by mistake.

Teurn commented 4 years ago

Any update of rotation and crop image feature?