search

minetest-mods / areas

A rewrite of the node_ownership Minetest mod with many new features.
GNU Lesser General Public License v2.1
51 stars 52 forks source link

Use AreaStore #13

Closed est31 closed 9 years ago

est31 commented 9 years ago

Use AreaStore data structure. See the minetest pr minetest/minetest#2898 which explains the speedups.

ShadowNinja commented 9 years ago

It seems like this introduces two area IDs: The one used in the AreaStore and the one used for everything else. There should only be one.

est31 commented 9 years ago

@ShadowNinja the two area ids are done because areastore does its own id management (to allow easier use), but it may set the ids differently each time (the API doesn't guarantee that its the same, every time). I think this should be hidden completely from the users, and the ids should be constant over restarts.

ShadowNinja commented 9 years ago

@est31: Yes, but if that's the issue I think the areastore should handle the IDs better, or just provide a way to pass your own ID, bypassing its auto-chooser.

kilbith commented 9 years ago

Will it be hopefully merged next year ?

davisonio commented 9 years ago

:+1:

ShadowNinja commented 9 years ago

I'll try to fix the issues I noticed and merge this now.

ShadowNinja commented 9 years ago

8b0b8c1ad26afdae906e9fd6332218d79a33bd1d