search

minetest-mods / areas

A rewrite of the node_ownership Minetest mod with many new features.
GNU Lesser General Public License v2.1
51 stars 52 forks source link

Add support for playerfactions mod #37

Closed crabctrl closed 5 years ago

crabctrl commented 5 years ago

Hello, I'm still pretty new to Minetest mod development in general so please correct me if I'm going about this wrong.

Frustrated by the lack of a way to manage allowing large groups of people to access certain areas, I've developed a factions mod which allows players to create and invite each other to factions. There's currently some room for improvement within the factions mod itself, but it is functional in its current state.

I've written some patches for the areas mod to allow players to control access to their areas using factions. It's an optional dependency of course, so existing users are completely unaffected. Specifically, it adds one command, /area_faction_open <ID>, which functions exactly the same as /area_open <ID> except that it opens/closes the area to faction members only.

I've done some testing on my own, and it seems to work fine. If somebody else would like to test it I'll be happy to help in any way I can. The actual factions mod can be found here.

Thanks for your time!

crabctrl commented 5 years ago

Thanks for the review, the code has been updated accordingly

crabctrl commented 5 years ago

I've updated the code yet again; thank you for your patience

SmallJoker commented 5 years ago

Will merge in a few days to see whether any other change requests appear.

crabctrl commented 5 years ago

It's been a cool three days now; time to merge?