Luacheck ci - Githubissues

minetest-mods / areas

A rewrite of the node_ownership Minetest mod with many new features.

GNU Lesser General Public License v2.1

51 stars 52 forks source link

Luacheck ci #44

Closed BuckarooBanzay closed 4 years ago

BuckarooBanzay commented 4 years ago

this PR adds:

the remaining luacheck fixes
a github action for luacheck execution on PR's and commits

BuckarooBanzay commented 4 years ago

legacy globals are removed, the legacy.lua file has still 2 (ignored) issues:

    legacy.lua:83:2: loop is executed at most once
    legacy.lua:104:2: loop is executed at most once

but IMO: they should be done in a later PR, goal of this was initially to introduce luacheck in a ci pipeline. But this grew to a legacy cleanup spree...

SmallJoker commented 4 years ago

Will merge in the next few days unless there are objections by other devs.