Replace deprecated hud_elem_type field in main HUD

minetest-mods / areas

A rewrite of the node_ownership Minetest mod with many new features.

GNU Lesser General Public License v2.1

51 stars 52 forks source link

Replace deprecated hud_elem_type field in main HUD #78

Closed Emojigit closed 4 months ago

Emojigit commented 4 months ago

This PR replaces hud_elem_type in the HUD definition with type. This PR is ready for review.

Niklp09 commented 4 months ago

Replacing hud_elem_type w/ type breaks huds on servers running Minetest 5.8.0 and lower. This isn't a problem here since mt uses text if no type is set.

SmallJoker commented 4 months ago

~~Suggestion: use minetest.get_player_information to determine the field name.~~ EDIT: Incorrect assumption that this issue is somehow on client side.

Emojigit commented 4 months ago

Suggestion: use minetest.get_player_information to determine the field name.

According to the documentation, hud_elem_type is ignored when type is present, so I will keep both.

Done in https://github.com/minetest-mods/areas/pull/78/commits/767d0e1f25faea20737e8ac86653af9d19d20f7f