minetest-mods / item_drop

A highly configurable mod providing item magnet and in-world node drops
https://forum.minetest.net/viewtopic.php?t=16913
GNU Lesser General Public License v2.1
13 stars 12 forks source link

Make mined items missable, for fun #41

Open Poikilos opened 9 months ago

Poikilos commented 9 months ago

It is fun and challenging if it is missable. I started working on it locally but started an issue since the CONTRIBUTING file says to discuss changes involving changes to defaults. This would require:

I started working on it locally but started an issue since the CONTRIBUTING file says to start an issue to discuss changes involving changes to defaults.

What do you think? It would be more like MC (along with default pickup_radius .4, magnet_radius 1.4). I'm not saying being like MC is always good, just that these settings (and potentially code changes) provide a good result.

Some other code changes are necessary to re-enable gravity on the item after magnet_time or pickup_age finishes, etc. I got it working on my local copy.

:edit: It seems to work fine with the following defaults (no code changes would be necessary except defaults--The problem I was having that would require further changes to fix manually dropping items was a bug where MultiCraft wasn't setting dropped item entity's dropped_by string):

item_drop.magnet_time = 3.0
item_drop.magnet_radius = 1.4
item_drop.pickup_age = 2.5
item_drop.pickup_radius = 0.4

:edit: These values need tweaking. I will get back to this.