search

minetest-mods / vehicle_mash

Cars, boats, and hovercrafts for Minetest
https://content.minetest.net/packages/Panquesito7/vehicle_mash/
Other
8 stars 10 forks source link

What licence is the code in this repo? #10

Open Lazerbeak12345 opened 2 years ago

Lazerbeak12345 commented 2 years ago

This... is a hairy licencing issue.

But what about the code in ./framework.lua? What about other code not from the above?

Todos

Since there is some work to do here apparently:

Panquesito7 commented 2 years ago

Good catch. Actually, the Car textures from Esteban are under CC BY-NC-SA, but that's only the textures, there's no code included for that. The code itself should be MIT.

Hopefully, @blert2112 knows more about this. Thank you. 🙂

Lazerbeak12345 commented 2 years ago

I think what this mod does at the bottom of the README is a great solution: https://github.com/minetest-streets/streets but you must be sure it's accurate. (that is - I like that there's a catchall. It means that all new code modifications are covered)

Lazerbeak12345 commented 2 years ago

upon some research the hovercrafts mod is currently under the LGPL 3.0 or later. Keep in mind - that's the current licence, not necessarily what it was under when @blert2112 forked it into this mod.

Panquesito7 commented 2 years ago

That's a fork of the hovercrafts mod. The license details for the original one can be found here https://github.com/stujones11/hovercraft/blob/master/LICENSE.txt

Lazerbeak12345 commented 2 years ago

I see. The original is LGPL. Was it under that licence when vehicle_mash forked it?

blert2112 commented 2 years ago

Let me see of I can clarify... if I can recall correctly. There is no code from all these other vehicle mods. It's is only the textures/models. I tried to link their relevant threads when I could. The code of the mod itself is basically just a registering type thing. Something to say "hey, I exist and these are my values", lib_mount handles everything else. TBH, I probably got this idea straight from mobs_redo as I was working on features for that at the same time. I did this because when my server was running I found that there was a crap ton of duplicated code throughout many of the mods I was using. Vehicle_mash and lib_mount allow you to take whatever models and textures you want and, given the correct values for registration, use them without all the code duplication. Pretty sure at one point I even had the dragon working but I may have lost that section of the project years ago. Hope that clears it up some.

To sum up... there was no Forking of the various mods vehicles came from (which, BTW, were all just forks of PilzAdam's original boats mod) just the textures/models.

blert2112 commented 2 years ago

The license info was correct and as up to date as possible when I originally wrote the readme.

Lazerbeak12345 commented 2 years ago

Sounds like the licence for new code changes should be that of the Boats mod.

Panquesito7 commented 10 months ago

This issue is very old, but, in this case, the license for the code would be WTFPL. I suggest we should change it to MIT or the most appropriate license. I'm not sure if we need to ask the contributors for this, though.