Schedule UI improvements

minnestar / sessionizer

Conference session management application

http://sessions.minnestar.org

MIT License

29 stars 23 forks source link

Schedule UI improvements #145

Closed pcantrell closed 7 years ago

pcantrell commented 7 years ago

A grab bag:

Schedule page now works even if sessions don’t have rooms yet. This is in anticipation of getting the schedule out early this year, and assigning rooms only later.
The schedule — and the whole app! — should always show dates in Central Time, regardless of the user’s device’s time zone.
Fixed broken CSS/JS includes (probably got hosed during the Rails 5 migration?).
Mopped up some layout stuff that got messy with incremental fixes over the years.
Fixed broken URL in http → https admin redirect. (Should we force https site-wide?)

coveralls commented 7 years ago

Coverage increased (+0.4%) to 56.062% when pulling 3372a9256611d73cd65b8d1843b28f21d05fe124 on schedule-ui-improvements into c714c76268a7d087cb18d993dcdec5d224127540 on master.

coveralls commented 7 years ago

Coverage increased (+0.3%) to 55.982% when pulling 3372a9256611d73cd65b8d1843b28f21d05fe124 on schedule-ui-improvements into c714c76268a7d087cb18d993dcdec5d224127540 on master.

jcoyne commented 7 years ago

By in large these changes look good. Generally it would be helpful to other maintainers if you would add a bit more method documentation.

pcantrell commented 7 years ago

I added a few light comments. Justin, LMK if there's stuff left that still seems unclear to you.

jcoyne commented 7 years ago

@pcantrell thanks man! 😎