search

minnestar / sessionizer

Conference session management application
http://sessions.minnestar.org
MIT License
29 stars 23 forks source link

Fixes the routes override of the admin configuration checkbox #146

Closed caseyhelbling closed 7 years ago

caseyhelbling commented 7 years ago

This allows us to dynamically toggle the schedule/sessions as the landing page.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+53.5%) to 53.765% when pulling d4a33aee69540e0fbb71216a7468bbc79695508d on fix/allow-schedule-home-toggle into 6471be32ddcc26f3419ace557bd762daab6a9aab on master.

look commented 7 years ago

Haha, that quick hack only lasted 7 years. 😉

jcoyne commented 7 years ago

See https://github.com/minnestar/sessionizer/commit/d8e83277cb4e3dc3cf4959d3a297f3ad435aab76

jcoyne commented 7 years ago

I see, this is fixing a regression in https://github.com/minnestar/sessionizer/commit/0778997d70fea216f235a5471d0152c6f03d570a

caseyhelbling commented 7 years ago

Yah. At some point I introduced a bug by manually overriding the checkbox by updating the routes file to point to pages#home. This undoes that hack so the schedules controller can actually do its job.

  def index
    unless Settings.show_schedule? || params[:force]
      redirect_to home_page_path
     return
    end