Add Remember me checkbox to login page

minnestar / sessionizer

Conference session management application

http://sessions.minnestar.org

MIT License

29 stars 23 forks source link

Add Remember me checkbox to login page #176

Closed experimatt closed 6 years ago

experimatt commented 6 years ago

Add a 'Remember me' checkbox to login screen so UserSession is remembered across sessions

coveralls commented 6 years ago

Coverage remained the same at 52.482% when pulling 54fb2075dd028272d00532afacdf0b5111336215 on mdecuir/login-remember-me into 9ab2c26f9e433e4c23825fb5a5219a5e9ca59506 on master.

experimatt commented 6 years ago

@caseyhelbling yeah, I wanted to test that it actually remembers your login after closing and re-opening the window, but I wasn't sure exactly how to do that within the current test structure of the app.

It seemed weird me to that there wasn't a user_sessions_controller_spec.rb, but I didn't want to create a new one with the limited time I had last night.

If you have ideas about how to better test that this functionality works as expected, I'd love to hear them!

experimatt commented 6 years ago

Merging... There's no downside here, I guess 🤷‍♂️