iPad Pro iPadOS 13.2 the window is clipped

mintware-de / flutter_barcode_reader

A flutter plugin for reading 2D barcodes and QR codes.

MIT License

628 stars 463 forks source link

iPad Pro iPadOS 13.2 the window is clipped #159

Closed StephanCassel closed 4 years ago

StephanCassel commented 4 years ago

iPad Pro iPadOS 13.2 the window is clipped, see pic. The scanner works but it doesn't looks good

Screenshot 2019-11-06 at 20 47 52

terry8204 commented 4 years ago

Have the same problem, need improve.

terry8204 commented 4 years ago

(void)showBarcodeView { BarcodeScannerViewController scannerViewController = [[BarcodeScannerViewController alloc] init]; UINavigationController navigationController = [[UINavigationController alloc] initWithRootViewController:scannerViewController]; scannerViewController.delegate = self; scannerViewController.modalPresentationStyle = UIModalPresentationFullScreen; navigationController.modalPresentationStyle = UIModalPresentationFullScreen; [self.hostViewController presentViewController:navigationController animated:NO completion:nil]; }

add two lines in the BarcodeScanPlugin.m scannerViewController.modalPresentationStyle = UIModalPresentationFullScreen; navigationController.modalPresentationStyle = UIModalPresentationFullScreen;

StephanCassel commented 4 years ago

Terry That is a very good finding. I guess barcode_scan package will soon be updated. Thanks to you and to the barcode_scan team.

chuanner commented 4 years ago

I have the same situation. The page looks ugly. I hope this problem can be fixed as soon as possible~~

Stephan-Enoro commented 4 years ago

Yes, it would be smashing. barcode_scan is an excellent package and we are depending on it. Thanks is advanced.

mikhail-karan commented 4 years ago

I'm having this issue as well and would love for the pull request that was created to be merged. Thanks!

devtronic commented 4 years ago

@StephanCassel: Please pull the master branch and check if the issue is still there. PR #167 contains a fix a similar problem

Stephan-Enoro commented 4 years ago

Hi @devtronic
Sorry about the delay. On journey. Everything looks very good. Thanks.