mintware-de / flutter_barcode_reader

A flutter plugin for reading 2D barcodes and QR codes.
MIT License
628 stars 463 forks source link

Fix for Issue #61 #167

Closed devtronic closed 4 years ago

devtronic commented 4 years ago

While the iOS device is rotating the bounds of the previewView will be recalculated and the scanRect will be reinitialized.

Changes in the WorkspaceSettings are necessary to run the example app

devtronic commented 4 years ago

Any news on this?

rjahn commented 4 years ago

... is it possible to test this fix?

devtronic commented 4 years ago

Only directly on a iOS device by running the example app. I tested it with my iPhone XR with iOS 13.3

rjahn commented 4 years ago

Ok, only with example app? I have my own app with the latest dependency. I guess this won't work?

rjahn commented 4 years ago

.... not clear enough: I tried to add the dependency as follows:

barcode_scan: git: url: https://github.com/apptreesoftware/flutter_barcode_reader.git ref: master

rjahn commented 4 years ago

If I rotate before showing the scanner, the interface has the right width. If I have portrait and open show the scanner, rotate it before scanning - the width doesn't change!

devtronic commented 4 years ago

You've to checkout the fix_issue_61 branch from the forked repo (https://github.com/mintware-de/flutter_barcode_reader/tree/fix_issue_61)

rjahn commented 4 years ago

OK, this branch works. But is it correct that the scan area is higher than the device height (landscape mode)? The green corner markers are not fully visible....

DavideBicego commented 4 years ago

This works ok but the Overlay area needs to be recalculated too so that it doesn't go out of screen. I've tested in an iPhone 6 running iOS 12.4.4

devtronic commented 4 years ago

I'll fix the size of the overlay this week

rjahn commented 4 years ago

Great!

devtronic commented 4 years ago

I'm still working on the fix for the overlay

devtronic commented 4 years ago

Finally 😎

IMG_0983

rjahn commented 4 years ago

Looks great, will try it asap!

rjahn commented 4 years ago

Verified, works great! Ready to merge?

devtronic commented 4 years ago

@matthewtsmith it would be great if you could take a look on this, thanks 🙂