Closed devtronic closed 4 years ago
Any news on this?
... is it possible to test this fix?
Only directly on a iOS device by running the example app. I tested it with my iPhone XR with iOS 13.3
Ok, only with example app? I have my own app with the latest dependency. I guess this won't work?
.... not clear enough: I tried to add the dependency as follows:
barcode_scan: git: url: https://github.com/apptreesoftware/flutter_barcode_reader.git ref: master
If I rotate before showing the scanner, the interface has the right width. If I have portrait and open show the scanner, rotate it before scanning - the width doesn't change!
You've to checkout the fix_issue_61
branch from the forked repo (https://github.com/mintware-de/flutter_barcode_reader/tree/fix_issue_61)
OK, this branch works. But is it correct that the scan area is higher than the device height (landscape mode)? The green corner markers are not fully visible....
This works ok but the Overlay area needs to be recalculated too so that it doesn't go out of screen. I've tested in an iPhone 6 running iOS 12.4.4
I'll fix the size of the overlay this week
Great!
I'm still working on the fix for the overlay
Finally 😎
Looks great, will try it asap!
Verified, works great! Ready to merge?
@matthewtsmith it would be great if you could take a look on this, thanks 🙂
While the iOS device is rotating the bounds of the previewView will be recalculated and the scanRect will be reinitialized.
Changes in the WorkspaceSettings are necessary to run the example app