feat: added cancel for ux

mintware-de / flutter_barcode_reader

A flutter plugin for reading 2D barcodes and QR codes.

MIT License

628 stars 464 forks source link

feat: added cancel for ux #198

Closed iRaySpace closed 4 years ago

iRaySpace commented 4 years ago

There are users that doesn't know back button. Added the Cancel button for UX purposes. Only modified for Android. Haven't done for iOS Cancel

devtronic commented 4 years ago

Thanks for contributing 🙂

Please merge the current master branch in your branch. I also added few notes to your changes

iRaySpace commented 4 years ago

Hello, can you check? Not sure, if I did right.

ccfiel commented 4 years ago

@devtronic when will this merge? :)

devtronic commented 4 years ago

I'll review the changes today

ccfiel commented 4 years ago

@devtronic thanks for the update 😊

devtronic commented 4 years ago

@iRaySpace I can't build the project since there is a variable getting defined twice. I added a comment on the corresponding line in the BarcodeScannerActivity.kt. After you fixed that I'll merge the PR.

iRaySpace commented 4 years ago

Hello @devtronic Thank you, and also I have put up the changes.