Closed devtronic closed 5 years ago
Any reasons why this PR is not getting merged?
Sorry for the slow reply. I have a couple issues with the PR as it stands now.
Options
class that can be passed into the scan()
method. This would allow us to extend the options over time without creating a bunch of arguments in the scan
method.The call to open the scanner would look like
scan(options: new ScanOptions(flashOnText: "Flash On", flashOffText: "Flash Off"))
The Options class constructor should have reasonable defaults. the options
should allow null and if so, apply some reasonable defaults.
Thank you for your reply. I'll fix that asap.
@devtronic Are you going to continue work on this API extension?
Hi, yes I've bought a MacBook that I can also extend and test the iOS code.
Please review 🙂
Are my changes ok, @matthewtsmith ? :-)
@matthewtsmith It would be very nice if you could give a short feedback if the changes are good and when you will merge this PR.
Hello everyone! I create the file "scanner_options.dart"
But in the file "main.dart" does not recognize me the import.
What can I do to correct the problem? Thank you!
The text for "Flash On" and "Flash Off" can now be passed to the scan method
String barcode = await BarcodeScanner.scan("Flash On", "Flash Off");