mintware-de / flutter_barcode_reader

A flutter plugin for reading 2D barcodes and QR codes.
MIT License
628 stars 462 forks source link

Made Flash On / Off text variable #54

Closed devtronic closed 5 years ago

devtronic commented 5 years ago

The text for "Flash On" and "Flash Off" can now be passed to the scan method String barcode = await BarcodeScanner.scan("Flash On", "Flash Off");

devtronic commented 5 years ago

Any reasons why this PR is not getting merged?

matthewtsmith commented 5 years ago

Sorry for the slow reply. I have a couple issues with the PR as it stands now.

The call to open the scanner would look like

scan(options: new ScanOptions(flashOnText: "Flash On", flashOffText: "Flash Off"))

The Options class constructor should have reasonable defaults. the options should allow null and if so, apply some reasonable defaults.

devtronic commented 5 years ago

Thank you for your reply. I'll fix that asap.

KamilZielinski commented 5 years ago

@devtronic Are you going to continue work on this API extension?

devtronic commented 5 years ago

Hi, yes I've bought a MacBook that I can also extend and test the iOS code.

devtronic commented 5 years ago

Please review 🙂

devtronic commented 5 years ago

Are my changes ok, @matthewtsmith ? :-)

devtronic commented 5 years ago

@matthewtsmith It would be very nice if you could give a short feedback if the changes are good and when you will merge this PR.

cristianfb1989 commented 5 years ago

Hello everyone! I create the file "scanner_options.dart" 01

But in the file "main.dart" does not recognize me the import. 02

What can I do to correct the problem? Thank you!