Localize the Flash On/Off button would be better

[learning]

The Flash On/Off button text is hard coded now, localize it would be better.

https://github.com/apptreesoftware/flutter_barcode_reader/blob/5d498e39a76466b03579486475ec777fba33ed2c/android/src/main/kotlin/com/apptreesoftware/barcodescan/BarcodeScannerActivity.kt#L39

https://github.com/apptreesoftware/flutter_barcode_reader/blob/5d498e39a76466b03579486475ec777fba33ed2c/android/src/main/kotlin/com/apptreesoftware/barcodescan/BarcodeScannerActivity.kt#L43

https://github.com/apptreesoftware/flutter_barcode_reader/blob/5e360fc9dad8f3525e75aaaf6e7d64490759eda2/ios/Classes/BarcodeScannerViewController.m#L93

https://github.com/apptreesoftware/flutter_barcode_reader/blob/5e360fc9dad8f3525e75aaaf6e7d64490759eda2/ios/Classes/BarcodeScannerViewController.m#L97

[angel1st]

+1 on the above. I would even suggest an easier IMO approach - rather than localize the button, it can be replaced with icon pair Flash on / off.

[gabrieleleo]

would be really awesome!!

[linguitang]

+1

[hehuapei]

+1

[josephyuen]

+1

[hanlike]

+1

[masewo]

+1 on the above. I would even suggest an easier IMO approach - rather than localize the button, it can be replaced with icon pair Flash on / off.

I replaced flash toggle title by two icons in my fork.

[devtronic]

As mentioned here https://github.com/mintware-de/flutter_barcode_reader/issues/131#issuecomment-588521486 I need to rewrite the platform communication. After that it's possible to use custom strings.

[devtronic]

Soon :-)

[devtronic]

Feel free to test: https://github.com/mintware-de/flutter_barcode_reader/pull/185

[devtronic]

https://pub.dev/packages/barcode_scan/versions/3.0.0-dev.1