search

minyoungg / vqtorch

MIT License
101 stars 9 forks source link

Update setup.py #9

Closed juntaowang99 closed 6 months ago

juntaowang99 commented 6 months ago

Hi, @minyoungg . Thanks for the great work. I'd like to point out one issue which may result in CUDA device issue.

Your install requirements are

install_requires=[
            "torch>=1.13.0",
            "string-color==1.2.3",
            "torchpq==0.3.0.1",
    ],

in setup.py.

However, in torchpq-0.3.0.1, there is a bug that they always create new tensors on cuda:0, it is a problem for those who have multiple devices. The author of torchpq fixed the bug since version 0.3.0.3 (see link).

So I suggest you update the install requirements in setup.py to 

install_requires=[
            "torch>=1.13.0",
            "string-color>=1.2.3",
            "torchpq>=0.3.0.3",
    ],

Best, Chris :)