mirapy-org / mirapy

MiraPy: A Python package for Deep Learning in Astronomy
https://mirapy.org/
MIT License
44 stars 10 forks source link

Added train function in Classifier class #24

Closed akhilsinghal1234 closed 5 years ago

akhilsinghal1234 commented 5 years ago

modified model and added train to models.py

pep8speaks commented 5 years ago

Hello @akhilsinghal1234! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 6:80: E501 line too long (80 > 79 characters) Line 18:80: E501 line too long (80 > 79 characters) Line 35:80: E501 line too long (89 > 79 characters) Line 40:38: W291 trailing whitespace Line 52:1: E265 block comment should start with '# ' Line 100:1: E265 block comment should start with '# ' Line 105:1: E265 block comment should start with '# ' Line 116:1: E265 block comment should start with '# ' Line 120:1: E265 block comment should start with '# ' Line 125:1: E265 block comment should start with '# ' Line 129:1: E265 block comment should start with '# ' Line 142:80: E501 line too long (80 > 79 characters) Line 171:80: E501 line too long (88 > 79 characters) Line 178:80: E501 line too long (80 > 79 characters)

Line 4:80: E501 line too long (82 > 79 characters) Line 20:80: E501 line too long (93 > 79 characters) Line 29:80: E501 line too long (89 > 79 characters) Line 30:80: E501 line too long (102 > 79 characters) Line 35:1: E402 module level import not at top of file Line 36:1: E402 module level import not at top of file Line 38:1: E402 module level import not at top of file Line 41:1: E402 module level import not at top of file Line 43:1: E402 module level import not at top of file Line 44:1: E402 module level import not at top of file Line 139:80: E501 line too long (99 > 79 characters) Line 151:1: E124 closing bracket does not match visual indentation

Comment last updated at 2019-05-02 11:49:10 UTC
swapsha96 commented 5 years ago

@akhilsinghal1234 LGTM. I'll merge it after Travis build passes.