misakuo / svgtoandroid

Converting SVG to VectorDrawable
https://plugins.jetbrains.com/plugin/8103
MIT License
528 stars 45 forks source link

Improve format of generated resource #19

Closed igorwojda closed 7 years ago

igorwojda commented 7 years ago

Two things that can be improved

  1. OrderOfAttributes - pathData attribute can sometimes take be long so I thing it should be placed at the end of attributes list (now for ex it's difficult to change color without scrolling all the way right) orderofattributes

  2. PreformatedCode (each attribute in new line) preformatedcode

misakuo commented 7 years ago

Thanks for your feedback, I think order of attributes is more viable, the generated source will be reformatted according to the default configuration by plugin, so, each attribute in new line might be more difficult to achieve. I will release a new version with the attribute ordering features as soon as possible

misakuo commented 7 years ago

The newest version 1.6.2 could be work well

igorwojda commented 7 years ago

I have noticed that running format code command and changes order of the attributes (and also format it properly), so maybe you could simply run it it on newly generated file

misakuo commented 7 years ago

Unfortunately, the behavior between reformat code command and invoking CodeStyleManager#reformat() method is different, so could not reformat xml on code as your expect, it also bothered me :(

igorwojda commented 7 years ago

I assume you did proper research on this, so if it's not possible, just close this ussie.

Thanks for fix ;-)

misakuo commented 7 years ago

I will continue to try to solve this problem, thanks for your feedback again.