Final Project Version - Instructor Feedback

[pawaitemadisoncollege]

Hi @misterSokor! In the interest of time, I am limiting feedback to areas for improvement. I am listing the questions I asked in Slack related to your presentation here, followed by feedback on each rubric category.

Your presentation did a good job clearly explaining the problem your application solves and leading into other opportunities, as booking time could be used for a wide variety of service appointments.

A few questions for you

1. I noticed after the user logs in, the username is placed in the session, and then it is later placed in the “model”. Can you share how and why you chose to put the username in two places?
2. Related to 1: Can you also share the scope of the “model” and how it relates to the various scopes we’ve used in adv java and ent java: page, request, session, and application (servlet context)?
3. I think I may have missed something related to the design: you indicated a timeslot could have many bookings. Does that mean a timeslot on Friday, Dec 29, at 1 p.m. could have multiple bookings? If so, how is this possible?
4. I’m curious if the two tables are really necessary. If you moved the username to the Timeslot table, could you remove the Booking table? It doesn’t look like the status is really used as this code deletes the booking if it’s cancelled? Is that right? https://github.com/misterSokor/TimeSlotManager/blob/4784f93ee736b1921062b63c43c84e[…]java/com/petersokor/TimeSlotManager/service/BookingService.java
5. Last thing! You mentioned that spring routed automatically to your error page when something went wrong. How does spring “know” which error page to use, i.e., where is that configured?

Feedback by rubric category

Project effectively utilizes the technologies and techniques specified in the project objectives

• [ ] Does not appear to consumes at least one web service or public api (in addition to those required) using Java.
• [ ] Does not appear that database includes multiple one to many relationships. There is currently one one-to-many relationship that may not be needed - see questions in first section above.
• [ ] Adding a user table may make more sense in this application and add the opportunity for more user-friendly functionality.
• [ ] Not deployed to AWS.
• [ ] Some best practices missed - validation for example. Rather than forcing the user to enter a name when booking, pre-fill the username when they book a time. This would also help ensure you know who made the booking - currently anyone could enter anything they like for the name.
• [ ] some data is shared in the publicly accessible repo that should not be public. Examples: .pem, .crt, cognito properties.

Synthesis of multiple concepts in unfamiliar situations requiring research beyond the scope of the class.

• [ ] Springboot falls into this category, but it seems that this was implemented without a complete understanding of the pieces that Springboot handled for you.

Code is readable, documented, efficient and well-tested.

• [ ] Missing proper documentation throughout the application.
• [ ] Unit testing should be improved to use a test database. - this feedback and the reasoning was provided previously.
• [ ] Update case appears to be missing.
• [ ] Some redundant code - for example, the properties appear to be loaded in two classes: Auth and LogIn.
• [ ] Username is placed in session and model?
• [ ] Some hard-coded strings such as "free" and "booked". These would be better as constants or an enum.
• [ ] Does logout controller really log the user out - from cognito and destroys any session data? It appears that it currently just returns a string?
• [ ] Is the status of booked or free necessary? Isn't it booked if there is a record in the booking table?
• [ ] How are available timeslots used? https://github.com/misterSokor/TimeSlotManager/blob/4784f93ee736b1921062b63c43c84e6f7ffe9195/src/main/java/com/petersokor/TimeSlotManager/controller/ScheduleController.java#L39, and https://github.com/misterSokor/TimeSlotManager/blob/4784f93ee736b1921062b63c43c84e6f7ffe9195/src/main/java/com/petersokor/TimeSlotManager/controller/ScheduleController.java#L42-L43. It seems like the front end does not use it? https://github.com/misterSokor/TimeSlotManager/blob/4784f93ee736b1921062b63c43c84e6f7ffe9195/src/main/resources/templates/schedule.html#L47

Demonstrates initiative and thoughtful planning to leverage available resources (time, equipment, external expertise) and meet milestones.

• [ ] Lacked thorough planning - all milestones missed.

Evidence of significant revision and incorporation of feedback.

• [ ] Some feedback was implemented, but many key items were not addressed. Refer to items in issues.

Complexity

• [ ] Overall complexity would be improved by including more functionality - such as adding a user to a user table when they sign up, improving unit tests to use a test database, providing an admin with a way to add days/times to the schedule, email capability, etc.

[misterSokor]

Hi Paula! Thank you a lot for a detailed review, I will work on it now. Do you think I have any chance for me to get better grade in case I will do it? May be I will not be able to do all of it, can you please say what is crucial for me to do?

[pawaitemadisoncollege]

First, it is best to devote some time to completing your learning tracker to really understand where you are in each of the competencies. Include the details not only of why you think you've earned the rating you chose, but also document what specifically you feel you would need to do to reach the next level, if applicable. Send me a slack message per the instructions I shared earlier and I'll review and provide feedback.

[misterSokor]

Hello Paula! Thank you for your time and extra time but do you really think I am here? Copy from Learning tracker: There is no description for a D or F, because these grades represent a fundamental breakdown of expectations. A “D” represents a meaningful but unsuccessful attempt at earning a C or above. An “F” represents such a severe lack of engagement, effort, or understanding that there is no evidence of meaningful progress.