Closed mistervee closed 4 years ago
Feedback from Gibxxi/Dan
Just taken another look and realised why the synopsis is "right-justified". It's because of the lack of the scrollbar for some shows with a short synopsis. Also the slider button and the text are right next to each other. If it were me, i'd keep the scrollbar on the (traditional) right-hand-side, and make it always active / visible but maybe hide or "grey-out" the button to make it obvious it's not required in that case. This will present consistent look and avoid having to re-justify the text for short synopsis text blocks that do not require a scrollbar. Also, a small margin between the text and said scrollbar (3-4px) would make it look a little neater (IMHO).
@bartolomesoriano @gibxxi @Slipass
Giving some thought to only providing feedback to one area at a time (i.e. Theme/Color picker) that may not be the best approach.
I have realized, (thanks to feedback from @gibxxi) that feedback for everything is better. I do know there are many unfinished area and things do not work as expected in some views.
So please post whatever you like, anything that you think needs updating, fixed, changed, suggested improvements or what ever you do and do not like. Even for what you think is unfinished as i can get it in a semi functional/polished state.
So then i will either comment it out from the code or do some adjustments for the short term.
EDIT: I think everything should look good and function nicely regardless on what part of the code i am working on. I get too focused on one part of the skin and neglect other parts with updates, and have often (over the past year) break other parts of the skin with out updating other areas. So yeah feedback for what ever you like.
As everyone here has full access to github, you can open new issues. What ever you want to do. So please be as detailed, OCD'd, criticize, complain and be as constructive as you like https://github.com/mistervee/skin.madnox/issues/new
The only thing i ask is do not push anything to github.
@mistervee, I was looking into the colorbox script error in DialogVideoInfo.xml. It seems that the script author does not support much anymore the running of the script via RunScript(), and the preferred method is using the daemons provided by the script, which is a whole different way of running it. Look here: https://forum.kodi.tv/showthread.php?tid=318626&pid=2696277#pid2696277
Perhaps that is the answer, or else will have to code the using of colorbox via the daemons.
@bartolomesoriano Makes sense. But strangely enough, today, i open Kodi and no more error?
Feel free if you want to try to get it working.
I had a quick look and it seems i will need to invest loads of time in understanding the script as there is not really any Wiki of sorts. So for me i will look at this way down the track or remove it all together.
@mistervee, I did what that post suggested (enclosing the image name in $ESCINFO[]), and the error went away. However, I don't know if it is doing what you wanted to achieve, since I cannot see any changes in the poster image in the dialog. Could you try that and see if it is working? Or let me know what you were trying to achieve? I know there's very little documentation, but I see it as a challenge of sorts. Please let me know what you wanted to do with the poster in the dialog, and I will figure out how to achieve that with the script and post here what changes would be required. Thanks!
EDIT: I tried the latest Leia nightly 64-bit (Oct. 14) and I still get the error with the unmodified dialog. I am using the latest version available in Git of the colorbox script.
@mistervee
Aeon Nox had a "Power Menu" which had only one function, to bring up the shutdown dialog box. I don't think we need a dedicated "Shutdown" menu item on the main menu, but for those who run Kodi, only using a remote control, especially for those without a built-in alphanumeric keyboard, relying on the "S" shortcut alone will make exiting Kodi / restarting more difficult.
With that in mind, would it be possible to add a "Power" option to the "System -> Submenu" item, so that we can invoke the shutdown pop-up dialog from there?
@gibxxi You don't have to rely on the S key for power. What @mistervee has in MadNox is that on the main menu, if you press down once, you'll get to the submenu for that option, and if you press down again you get to a bottom tab that has Power, Search, Favorites, Update Library, Disc and Eject Disc. These options for the bottom tab are configurable in Skin Settings.
@mistervee , I am seeing these errors in the log:
INFO: Error loading include file C:\Users\bsori\AppData\Roaming\Kodi\addons\skin.madnox\16x9\script-skin_helper_service-includes.xml: Failed to open file (row: 0, col: 0)
11:12:48.182 T:22244
ERROR: Error loading include file C:\Users\bsori\AppData\Roaming\Kodi\addons\skin.madnox\16x9\Custom_Overlay.xml: Root element
The first one I understand is because we don't have that file in the skin, but the second one I don't understand. I looked at the Custom_Overlay xml and could not find anything wrong with it.
@mistervee, there are some more errors I am seeing in the log. I will post here for your review.
WARNING: Skin has invalid include: FullScreenDimensions From what I could see, this is because this include is in Includes_Temp.xml, and this file is not being referenced so it can be loaded in Includes.xml.
WARNING: Skin has invalid include: Animation_Slide_Right This include is not in any of the xmls for the skin.
WARNING: Skin has invalid include: Animation_VisibleFade From what I could see, this is because this include is in Includes_Temp.xml, and this file is not being referenced so it can be loaded in Includes.xml.
WARNING: Skin has invalid include: Animation_WindowFade This include is not in any of the xmls for the skin.
[Warning] CGUITextureManager::GetTexturePath: could not find texture 'lists/focus.png' [Warning] CGUITextureManager::GetTexturePath: could not find texture 'buttons/thumbnail_focused.png' [Warning] CGUITextureManager::GetTexturePath: could not find texture 'panels/topbar-shadow-empty.png' DEBUG: [Warning] CGUITextureManager::GetTexturePath: could not find texture 'panels/topbar-shadow20.png' [Warning] CGUITextureManager::GetTexturePath: could not find texture 'views/scrollbarbacklist.png' [Warning] CGUITextureManager::GetTexturePath: could not find texture 'separator2.png' [Warning] CGUITextureManager::GetTexturePath: could not find texture 'buttons/button-focus.png' These textures are not in the skin folder.
WARNING: Label Formating: $VAR[SystemBackground] is not defined WARNING: Label Formating: $VAR[MusicBackground] is not defined WARNING: Label Formating: $VAR[VideoBackground] is not defined These variables are not defined in any of the XMLs.
These are all of the ones I think you should take a look at. There are more, but they relate to parts of the skin not yet recoded, like PVR and other views (right list, info list).
Ah, thanks for that. I think he mentioned that before. I'd forgotten about it.
:)
On Oct 14, 2018 3:48 PM, bartolomesoriano notifications@github.com wrote:
@gibxxihttps://github.com/gibxxi You don't have to rely on the S key for power. What @misterveehttps://github.com/mistervee has in MadNox is that on the main menu, if you press down once, you'll get to the submenu for that option, and if you press down again you get to a bottom tab that has Power, Search, Favorites, Update Library, Disc and Eject Disc. These options for the bottom tab are configurable in Skin Settings.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mistervee/skin.madnox/issues/22#issuecomment-429632373, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGyQ6kN3MSLZ5G6EhsrYHOBmLZDUl3LLks5uk06wgaJpZM4XMEjp.
@bartolomesoriano I fixed some of the log errors you have mentioned.
The PVR area you should expect log errors as that is not complete. Mainly in the guide xml.
The missing textures are due to the many changes/updates/OCD in improving textures. Using a spreadsheet i am trying to keep track of what i have not reviewed.
Hopefully when an Alpha version is close i will have resolved most of the errors, then i will post the spreadsheet on git.
So for now i would not think to much about any log errors that are in the skin.
EDIT: The script-skin_helper_service-includes.xml error is likely to do with not selecting any backgrounds the skin helper service scripts provide. Need to think about how to handle this in future. If you go to the side menu in settings and select a library background the error should no longer be present.
@mistervee, thanks. There is still one include that is used in a lot of places that is not defined because the only place where it is defined is in Includes_Temp.xml: FullScreenDimensions.
This is also not defined, which pertains to music:
19:27:48.747 T:26912 WARNING: Label Formating: $VAR[MainMenuNowPlayingMusicCaseVar] is not defined
I thought form the commits that you worked on the music part a bit, if this is not the case ignore this error.
On another note, I noticed that the scrollbar nib in the List view appears inside the texture, not straddling the edge of the texture, which I personally preferred. Was this change by design or is it maybe something to do with the aspect ratio of my laptop monitor?
@bartolomesoriano
Cheers for the bug reports.
Seems the 'S' was not uppercase in some xmls.
Updated the Case variable for now playing. Now playing is not complete but the error is no longer an issue.
Corrected the position of the scrollbar. That was something i missed when changing the main panel of the list view. My design choice was to center the texture on the edge of the panel, same goes for all the dialogs.
I am open to a change for the scrollbar. Not sure where i should position it or maybe improve the texture? Thoughts?
Talking of music, not sure if it's complete, so I'll post it here... "Wall View" in the music library is using movie poster aspect artwork, as a pose to square (like a CD case), noticed this the other day, but forgot to mention it.
@bartolomesoriano
Cheers for the bug reports.
Seems the 'S' was not uppercase in some xmls.
Updated the Case variable for now playing. Now playing is not complete but the error is no longer an issue.
Corrected the position of the scrollbar. That was something i missed when changing the main panel of the list view. My design choice was to center the texture on the edge of the panel, same goes for all the dialogs.
I am open to a change for the scrollbar. Not sure where i should position it or maybe improve the texture? Thoughts?
@mistervee, my opinion is to leave the scrollbar as you have it, on the right edge of panels. I noticed there are some panels where it is on the left edge; I need to look at it again to tell you which ones in particular. Was this by design?
@mistervee, I checked some more just now. The following panels do not have a scrollbar:
I saw the scrollbar on the left for the Subtitle language selection panel (in Settings, for which subtitle language you prefer).
I guess from those you can tell where you did not include the scrollbar and where you have it on the left. Please let me know if you need additional info. Thanks.
@gibxxi Wall view is not complete. I will get to updating the views when i have finished all other areas of the skin.
@bartolomesoriano The scrollbar position you see in the subtitle dialog was by design. In every view/dialog it is positioned directly left or right of the list it controls. How i decided what side of the the list was for ease of navigation.
I did however find some non related issues with the subtitle dialog. (missing rating, textbox size and scroll).
For the panels without a scroll bar, It is a coding mistake throughout the skin. I have used the same id for a lot of the scrollbars. So things are not working as intended. When i get to focusing on the views, i will fix the issue.
@mistervee: OK, just checking. :)
@bartolomesoriano and @all
All log error's should be fixed apart from what is listed here https://github.com/mistervee/skin.madnox/issues/34
If you have any issues please post in the above mentioned thread.
@mistervee, two issues:
As far as I can tell, the issue is that, in Variables.xml, in line 519, you need to replace [COLOR $VAR[MainMenuSubTextColorVar]]$LOCALIZE[3] : with [COLOR $VAR[MainMenuSubTextColorVar]]$LOCALIZE[20342] :
I took a closer look at the addon code, and it seems we are using outdated properties to show the info. There is no "StatusID" property anymore, just "Status", and there is no "Today" property anymore; I guess "NextDate" needs to be used and compared against today's date. I hope this info is useful.
@bartolomesoriano
Fixed
This is something that is bugging me. The skin is using the 'marcelveldt's beta repo'. In that repo is a update version of the 'Next Aired plugin' that seems to have some issues. Try going into addons/programs, context menu, then info. Press the refresh icon to change the version to the kodi repo one 6.0.15. marcelveldt's version is causing issues with widgets also in other skins.
This is something i need to look into further to see what i can update/improve, in regards to the use certain plugins.
@mistervee, thanks! Confirm that 1 is fixed and I will do as you suggest for 2.
@mistervee, with the 6.0.15 version of next aired plugin the info shown is correct.
I don't know if it's been posted yet......so double it up rather than nothing.
Currently, "List" and "Wall" are always preselected. If you select a different view, "List" and "Wall" also remain highlighted.
@Slipass:
Those aren't menu items m8, they're section titles, hence the colour. If you look, there are two "Liste" items and two "Wall" items in the sideblade. One is the section title, the other is the actual (selectable) menu item.
Dan / Gib.
@bartolomesoriano @gibxxi @Slipass
Hi all,
Hope you had a great Christmas and new year.
I have just pushed an update to git.
I have decided to move onto the library views for now, as i needed a change of pace with the coding. I will get back to the other areas of the skin at some point.
This is a WIP and bug reports are NOT required. There is a lot i have broken and not finished, just needed a git backup in case of a PC meltdown.
I do have a few questions though, any assistance, feedback would be great;
Option 1 is the easiest to code. Option 2 has a few more visibility conditions, and not so hard to code. Option 3, makes the code more complex and introduces a lot more overhead. and may have a small impact on performance.
My preference is option 2. I either want to show the topbar and floor in specific skin areas or not.
Just needing some thoughts on this in regards how you would use this feature.
I am looking for some one to volunteer to put a set of icon together using the google icon font. It is easy to do, just time consuming. It is a couple of clicks in a program i have to make 1 icon.
Cheers Mr. V
EDIT: If anyone one is up for helping point 2 or 3, i can get on discord to guide you.
@mistervee , thanks for the update! I will test this weekend.
As for the TopBar and Floor, I agree with you on option 2. I have never changed those for specific views and not others. I can help with the Default Icons. Just let me know what I need to do. I have not used Discord before, but that should not be an issue.
EDIT: @mistervee what is your Discord link? I created an account and server. I can provide my Discord link if you want.
I concur with option 2. I don't think adjustments "per view" are warranted, and if said option were to reset to defaults on each new view, I think it could cause a lot of frustration for some users, that's in addition to all the extra work required by you to code it.
I run different views per media type, so may wish to adjust floor options etc. based on that, so option 2 would suit my way of doing things.
I'll get it updated later and see what's new, welcome back btw.
;)
Dan / Gib.
I see it also. For me, option 2 is quite sufficient.
Regarding the icons and flags I will see if I can find something. Meanwhile I have changed all my clients to 4k and I also noticed something with madnox that the icons are pixelated. I don't know how easy it is to find something that is not copyright protected ;)
I'm also looking forward to seeing what news the skin has for the next few days.
I like the metal brushed variant.
What do you think of that?
@Slipass, I like those! I am not the creative type, so I would have to see a mockup of how they look with the skin to really give a good opinion.
@bartolomesoriano
@Slipass
I like the look of the brushed metal. It is not something i will use.
The mediaflags in question are the ones in the bottom right corner. https://imgur.com/a/GmeqwaW
All other icons in the top bar and media menu, i have higher resolution versions of those that could change. Just need to clarify which ones look pixelated.
I suppose i wasn't clear with the mediaflags. Some of them are a low resolution in the "media/flags" folder. For example white videocodec flags they are around 160x110 in size. They are coded to be 125x80. So they need to be at least 250x160 to be clear on a 4k screen.
@bartolomesoriano @gibxxi @Slipass
The list list view's will now be working for music and videos.
I have not coded any visibility conditions, as to restrict certain views. It is mostly working.
@mistervee great work so far on the views, thank you! I have tested with movies, tv shows, episodes, music videos, artists and albums. I have to say that right now my favorite is info list 2. Whenever you are ready for specific comments/issues/bugs, let me know.
Got some (minor) issues / enhancements / changes to talk about that were noticed while testing the "List Views" update over the weekend. I will list them in order of discovery...
Having previously set weather icons in the previous version, upon loading the updated version, I initially had no weather icons displayed. Had to change to a different set, and change back to get them to appear. This might be something my end, but I thought it worth mentioning just in case.
The "true" path to the currently selected / active background (for main menu backgrounds) is exposed in settings, including usernames and passwords (if a network share) rather than the name of the selected option, i.e: "Random Movie Fanart" - for example.
Upon entering the "Skin Settings" menu, no item is selected / highlighted by default.
Unable to select the "Close" button with cursor keys alone in some settings dialog boxes (First seen in Backgrounds Selection - Main Menu items).
After selecting a background option for a main menu item, and pressing "OK", focus returns to "General Settings" item, not the "Backgrounds" item, as expected.
A custom background option exists for "Add-ons" main menu item, but said main menu item does not exist in the "Edit Main Menu Section". Skin Shortcuts issue?
Conversely, there are no "Custom Background" options for TV Shows, Movies or Music Videos.
"Video Background" toggle button / slider does not stay enabled on subsequent re-visits to that screen.
Inconsistency between selections with a blue highlight, and the "Close Button" on dialog boxes that does not possess one. The glow effect is not enough of a difference to highlight that it's selected IMHO. That and I would advocate consistency across all selections in the skin. Keep the glow effect as well, but I think a blue highlight for the close button(s) would also be welcome here.
That's it for now.
Dan / Gib.
PS: The RSS Bar options are somewhat confusing. Options are: "Shadow" and "Wide". I'd name the "Wide" option something like "Bar" or "Solid" as neither option affects the overall width of the displayed feed itself. Also maybe name the option simply "RSS Feed" or "RSS Feed Display" as a pose to "RSS Bar".
Aside from the above, the overall speed is now much better, so thanks for that modification.
Dan / Gib.
@bartolomesoriano @gibxxi @Slipass
Now and again i am experiencing some lag with the skin. As far as i can tell this is due to skin helper service loading/downloading artwork. I want this skin to be fast and responsive in all windows.
I will be dropping support for 'Skin helper Service' 'Skin helper backgrounds' and 'Skin helper backup'.
What this will means is there will be no 'pvr' artwork apart form the channel icons, no artwork for radio streams. All other windows will have very little impact visually. When i coded the artwork for these areas, it has been constant trouble shooting, trying to figure out why skin helper was not working for some properties and why it was too slow. I spent more time on this than actually coding the entire view.
NOTE: I dont see a point in PVR artwork if it going to take 5 minutes to load all the artwork across dozens of channels every time you open pvr. Sure once they are loaded they are much faster, but wait an hour or two and a whole bunch of new shows are on. The process repeats. Personally if i watch live tv, i dont wait around for the artwork to load, i just choose what channel and play.
For the end user the biggest impact will be for people using kodi for illegal streaming. The user base i am not concerned about.
For legal streaming, spotify and netflix, they provide plenty of artwork so they will not be impacted.
From a coding perspective, the skin backgrounds will be reworked. Also the theme/color selector will be simplified, way to many options, this should compensate for not having a way to backup/restore themes.
Thought i would try to explain in detail, as some of you many not be happy with this choice.
Cheers Mr. V
@mistervee, I am perfectly fine with those choices. I will take a more responsive skin over having PVR artwork any day. The only thing I would like you to keep in mind is the possibility to set up, like you could with old MadNox, the background of any main menu item to be the fanart of the first widget for that main menu item. That is something I miss and used constantly. Thanks.
At the end of the day, since the developer responsible for those add-ons has been off-radar since before the Kodi 18.0 alphas came out, and the fact that everything he's ever coded has been somewhat riddled with bugs, I think your making the right choice.
3rd party helper add-ons are "OK" to a degree, but when the maintainer of said add-on(s) does go missing, it leaves those who've adopted them, up shit creek without a paddle.
Function over Form.
Dan / Gib.
Hi Mr. V
I also noticed that the skin reacts a bit slowly.
Especially the PVR artworks are loaded very slowly. I had already posted this in the forum. Therefore it is ok for me, if you stop the support of the addon.
Maybe there will be another solution in the near future to load the artworks.
Cheers all for your feedback.
Still tidying up the list views and work through your comments. Removing skin helper use from the list views has speed up the skin a lot. Not seeing any lag, apart from the home screen now where i am using skin helper backgrounds.
Wow just wow, even in this early stage the skin looks awesome!
It's super fast on my setup, it looks very clean and the customise option are already way to much...love it!
Very very nice work Mr.v, this will be the greatest skin in kodi history.
I will play around with it when I have some spare time and will post me feedback
Had a look at the new views, and like the sheer number of options. Nice work.
Have noticed a couple of potential issues (I'm using "Showcase" view for movies here)...
"Open Case" option opens case, even if there's no discart to place inside. Would be better if this animation is only triggered if there IS relevant matching discart to show.
"Show Logo" option does not fallback to the standard text if there's no logo for a given movie.
Not tested TV Shows at this time.
Dan / Gib.
P.S: While there is a "Press Up For Info" option, would also like to see the "Delayed Info display" option from Aeon Madnox make a return (I usually set mine to 5 secs).
Dan / Gib.
Just had a quick look at the TV Shows section... With Video Cases enabled, the TV station logos are correctly aligned and scaled in "Showcase" view, they're not in "Focus" view (too low and not scaled correctly). Also, while a nice idea in and of itself, on a 1080p screen, they're barely readable. I know your designing for 4K, but it might pay to put the info in the floor area as well, for the "Focus" view like your doing for the "Showcase" view.
Dan / Gib.
Hello together,
First of all, I think it's great how well the skin is developing. It looks really great.
The days I could test again a little. Here is my feedback
1: In movies and series it is not possible to have a view without the fanarts.
2: Even if I choose Single Image, it won't be showed
3: The Video Preview is only in full screen (background.
But I find this very impractical, because you hardly see anything of the video. Here I find the window mode (picture in picture) much better
The same as her (old madnox)
or here
4: There are no Disc Art Fallback
5: The Showcase View has no "fixed list" you can scroll infinitely. I find a "fixed list" better
6: No Box Art
7: Is it in the future possible to add other cases?
The sam as the old madnox
8: Wrong langugaes icons (wrong color)
Is fixed with the newest git Version (05/15/19)
9: The progress is not shown in the icons.
Old Madnox
10: In the Music view you cannot scroll in steps of 10
As here
11: The fanarts are no longer displayed because the logic is still based on the old artwork downloader.
12: I found the old info view in the movies a bit more clearly/structured.
Old madnox
12: Question: Will you also plan further views for music and radio plays? I liked the 3D view in the old Madnox
13: The old view at "LiveTV" was a bit clearer. The Info List 1 is not so nice as the "Complete overlay"
For example, the progress bar and the channel name are missing in the new Live TV
Old Version
14: LiveDVD Background still missing
15: Maybe I'm image but I can't find the repositories for the addons :)
16: I think the old Shadowbar didn't look so good and it fits better with the skin
Old Shadow Bar
17:The Pause menu is still missing
Old madnox
18: Is it possible that the submenu is only displayed when you press down? And the shadow is adjusted a little bit more to the old Madnox?
See my previous post about the shadow color. Same steps as previously outlined. But main menu settings.
The submenu, I can look at that in future.
Feedback from Gibxxi/Dan
Very nice. It looks suitably polished, I think you can be proud of this version of Madnox, even at this early stage. I would however suggest that you give end users an option to use the classic Aeon font for the main menu at least, as while the new one is OK, it does look a bit "squashed" if that's the right word, even on a 16:9 display. Also, I'd double the RSS feed scrolling speed (at least), as it's a bit on the slow side.
I'd stick with "Live TV" as a pose to just "TV" for the main menu PVR item by default, to clarify the distinction between "TV Shows" (i.e: rips) and "Live" broadcasts. Also, this is probably already on your todo radar, but in the library stats panel, i think it might be a good idea to also place the "Recordings" stats, alongside the number of channels, as before.
Issues:
In the info panel in "List View" there's an extra horizontal line that is above the bottom level of the info box (plot outline / synopsis), that interferes/intersects with the text as it scrolls. Also, text in that box seems to be right-justified rather than centre-justified at the moment. This applies to Movies and TV shows. None of the "Poster Views" are working, as well as some other views, but I'm guessing it's because you haven't completed these yet. "Wall View" works for videos (Movies and TV) but not for Music. "Wall - Info View" doesn't work for anything. Finally it's not possible to scroll down below "Wide List" in the Side-blade View Selector, whereas it is possible to scroll all the way if coming up from the bottom, however, "Big List" and "Landscape List" are skipped if doing so.