Closed mistervee closed 4 years ago
@mistervee sounds great! Great Xmas present for the Madnox fans! Can't wait to see all the features request in the forum ;P
I'm still using it at my daily skin and I'm very happy.
I'm moving to a new city around November so I can't use or test kodi around this time, but I'm looking forward to install Madnox asap on my new vero4k+ as soon as it is hooked up on the tv
Hi @mistervee
Glad to of been able to contribute. I am also happy to report that for the past month or so, I've been using Madnox 2.0 as my daily driver. I had been keeping Aeon Madnox (1.0) synched via GitHub as a potential fallback option, but this skin is now mature enough (in my view) for me to now be able to finally free up some space, and uninstall it (1.0).
All thanks to your efforts making the skin, so THANK YOU for coding it for the rest of us.
Have got an issue with (potentially) Artist Slideshow backgrounds showing in video sections, and over-riding video fanart (which I don't think ought to happen), while playing back music, but since you've stated you need to look at backgrounds, I'm assuming that is already on the radar?
Another issue is that (skin playlist) backgrounds don't appear until the databases are loaded, but I'm not sure if these are a feature of this skin, or script.skin.helper which I've now gotten rid of (due to issues it was causing elsewhere), but that does mean I won't be able to use any other skin that requires it as a dependancy. Not a big deal, since Madnox 2.0 is my skin of choice any way. Just mentioning it, in case it's relevant
:)
Dan / Gib.
EDIT: I answered my own question regarding the above (skin playlist backgrounds), and have reverted back to the default backgrounds the skin provides.
@meowmoo @gibxxi @bartolomesoriano @Slipass
Hi all hope is well. Loads of progress in the last couple of months and it is still looking likely an alpha release before christmas.
A massive update to git;
NOTE: _You will need to delete userdata\addondata\skin.madnox\settings.xml to remove any redundant settings. A lot of default settings have been changed and removed, there will be conflicts and odd skin behavior otherwise. On the home screen backgrounds and widgets have had some renaming. Anything not working will have to be reselected. If you are still having trouble you will need to reset the main menu.
Not working as intended and not complete;
It is time that anything goes for bug reports or missing features, not including the 'not working as intended' list Very close to alpha release and i would like to wrap up any lingering issues.
@gibxxi Everything relating to backgrounds should be complete and hopefully bug free. The music now playing background in the library views can be changed in skin settings or the media menu. I am hopeful any skin playlist background issues should be fixed.
@mistervee sound great, will update and test tonight!
Time for bug hunting
@mistervee
Roger that m8. Please see my comment here: https://github.com/mistervee/skin.madnox/issues/36#issuecomment-556165063
I'll check it out as and when I can.
:)
Dan / Gib.
@mistervee
Can you add the "recently-added" album info screen to the watch-list as well? The tracklist has a backdrop of album cover art sat behind it that bears no relation to the currently viewed album (or any other album in reccently added for that matter). This obscures the readability of the tracklist as well. If you need a screenshot, let me know.
EDIT: This is an issue noticed prior to this update, so if it has already been dealt with, please disregard this post.
Dan / Gib.
To clarify the above:
Go to "Recently Added" for music (albums), bring up the context menu for a selected album, and select the "Information" menu item.
Dan / Gib.
@gibxxi
Not working as intended and not complete; Music and Video info dialogs
;)
@mistervee thank you so much! I will be testing over the next few days.
@mistervee Thanks for the great update!!! Great work! It's smooth and stable.
I have a few remarks to make for the skin:
1: The Cover Background has no DVD Cover. Only CD Box Covers
2: There are no option to deactivate the fanart. Could you implement a solution to disable the fanarts and set a default background for everything?
3: Sometimes there are no suitable views available for addons. (TuneIn)
Madnox
4: Could you imagine building the info on series and movies like Madnox 1? The series in view (Low) still lack the ClearArts/Logos
Here from Madnox 1
@gibxxi
Not working as intended and not complete; Music and Video info dialogs
;)
@mistervee
OK m8, understood.
:)
Dan / Gib.
@Slipass
Cover Background fixed
Added option for videos, music and addons to disable fanart. Fallback background will be used if this option is enabled
The various views and options show depending on what the content is, albums artists, songs ect. It is up to the addon to set the correct content and fill kodi's infolabels. I will see if i can improve on this.
My opinion is that it looks cluttered in madnox 1.0. Not something i will change.
The logo. There is a bug i havn't fixed when you enable the video preview window.
@mistervee
With regards the "InfoLine" text for PVR, could you add the "Recordings" label & value alongside the "PVR Channels" item please? I like this "at a glance" item for recordings, to know if timers have executed as intended without having to dig down into sub-menus.
Also, I see an option for setting "Animated Fanart" in the "Now Playing" settings section, but nowhere to set "Main Menu Backgrounds" as animated. Am I being blind again?
Finally, in the Music Vis Screen, the settings for backgrounds are as follows:
Fanart, Extra Fanart, None.
I would put the "default" backgrounds in as a fourth choice, named "default", as the default backgrounds aren't "fanart", they're default backgrounds. Also, the "None" option should yield a black screen with just the visualisation, should it not? It displays the default background, behind the visualisation (undesired for this view IMHO). If this is covered by Slipass's request with regards being able to completely disable fanart, please disregard.
Dan / Gib.
@gibxxi
The info line for pvr currently works like this
If there is an active recording you will see this "Recording: recording title"
If there is no active recording and a timer is set then "Next: next recording title - next recording date/time"
If there is no active recording or timer then "PVR Channels: channel count"
I need some further clarification on how you would like it to work.
For everything else, i will try to get a fix today.
EDIT: Another option for recordings is to have a popup near the top of the screen like this https://imgur.com/xvihm04
In the case of the last case (i.e: No pending recordings for the current day), i'd like it to fall back to showing the number of existing recordings recognised by the PVR module (i.e: pre-recorded items waiting to be watched).
Cheers,
EDIT: Nice (new) default backgrounds by the way, was getting a bit tired of seeing those two from Breaking Bad, every launch, lol. Especially since I work with someone who looks like the older guy.
;)
Dan / Gib.
@gibxxi
Got it for the PVR. Will try to code something up today.
I was the same, really needed a change form the default ones, i like breaking bad, but too much of a good thing. Maybe you can buy him a porkpie hat for christmas. :tophat:
That reminds me, the new backgrounds are a copy and paste from a resource addon, i need to ask the author for permission to include them in the skin.
@gibxxi
Got it for the PVR. Will try to code something up today.
I was the same, really needed a change form the default ones, i like breaking bad, but too much of a good thing. Maybe you can buy him a porkpie hat for christmas. 🎩
That reminds me, the new backgrounds are a copy and paste from a resource addon, i need to ask the author for permission to include them in the skin.
OK. Thanks in advance Mr.V.
:)
Dan / Gib.
@meowmoo @gibxxi @bartolomesoriano @Slipass
Backgrounds updated as per suggestions.
@mistervee
Thanks for the update. I can't see the PVR fallback InfoLine at this time (as I have pending timers for today), I will provide feedback on this as and when I can. While we're on the subject of InfoLines, would it be possible to restore the "Installed Add-ons" InfoLine from previous versions, so the add-ons category has some homescreen info?
At the moment, the "Automatically Open Fullscreen Music On Play" setting is triggering at the start of every track, rather than only on playback start (i.e: at the start of the queue). This means if I'm navigating around Kodi settings at the time, e.g: (ironically) setting skin settings, and a track change occurs, i'll be taken back to the "Music Vis" screen and have to back out of it, back to where I was previously.
The "Dim Screen On Popup" Setting doesn't do anything on notification popups, so i'm assuming this is only for dialog screen type pop-ups? Just seeking clarification here.
This may be incomplete, but the "Skin Settings -> Furniture -> General -> Fullscreen Video" section has no settings, only a label marked "Info". Fullscreen Audio is working as expected.
The "Skin Settings -> Backgrounds -> Fallback / Custom Backgrounds -> Main Menu" item, has a pop-up dialog for single setting: "Animated Background". To simplify things, if no other options are planned here, I'd just have the toggle switch in the previous menu and dispense with the pop-up dialog. It's unnecessary extra button clicks just for one option IMHO.
Liking the simplified layout thus far. I like the way you've linked from OSD settings back to "Skin Settings -> Now Playing" as this is consistency. Some skins have settings scattered all over, and sometimes it's a royal PITA finding what you need / want to change when this is the case. With regards the sideblade, i'd keep any settings there strictly for the current "view" and not have any "general" skin settings in there, as seems to currently be the case.
Looking good m8, well done.
Dan / Gib.
@gibxxi
Just updated the pvr info lines. Also added a PVR widget that can be selected when editing the main menu.
The info line for addons was removed as that was supported with skin helper. There is no kodi label that will do this. I do need to look more into embruary help script, might be able to make something work with that.
Hopefully i have fixed the auto music option. Let me know.
The dim screen is only for dialogs that provide options to the end user.
Video now playing info in full screen video is not complete, that is what the setting is for.
The background setting for the main menu. It is a single option as i plan to add more in future.
Cheers for the feedback. Trying to make the settings consistent and easy to find. Thanks for noticing. For the area/general setting, not to sure how i could improve.
My thoughts; When you click view settings, it is all elements that will affect what you currently see. So under 'VIEW' they are view specific, under 'AREA' they are area specific like videos, pvr, music ect.
@gibxxi
Just updated the pvr info lines. Also added a PVR widget that can be selected when editing the main menu.
The info line for addons was removed as that was supported with skin helper. There is no kodi label that will do this. I do need to look more into embruary help script, might be able to make something work with that.
Hopefully i have fixed the auto music option. Let me know.
The dim screen is only for dialogs that provide options to the end user.
Video now playing info in full screen video is not complete, that is what the setting is for.
The background setting for the main menu. It is a single option as i plan to add more in future.
Cheers for the feedback. Trying to make the settings consistent and easy to find. Thanks for noticing. For the area/general setting, not to sure how i could improve.
My thoughts; When you click view settings, it is all elements that will affect what you currently see. So under 'VIEW' they are view specific, under 'AREA' they are area specific like videos, pvr, music ect.
With regards PVR: I don't use widgets, as I've said before, but thanks for the option. I'll check the existing InfoLines as and when possible.
With Regards the Addon InfoLine setting: OK, keep forgetting about the helper scripts. Not a big issue, just something nice to have, so no rush on that. Thanks for the clarification.
Will check Auto Music Vis option later, Kodi is busy streaming a radio show I listen to atm. ;)
With Regards Video Now Playing: Thought that might be the case, but decided to mention it just in case.
With regards Main Menu Background Setting: Understood.
With regards "Your Thoughts": I totally agree with you. That's the thing I was trying to point out (however badly worded) in my previous post.
;)
Dan / Gib.
@mistervee
Update: Auto Vis Option seems to be working as expected. Thanks!
Update 2: PVR now displays "Recordings" as well as "PVR Channels". Just what I was looking for, Thanks!
👍
Dan / Gib.
@mistervee
Is there / Will there be an option to disable the "Now Playing - Next" Widget on the Main Menu. I don't like widgets as a rule (unwanted clutter in my view). I don't mind this being there - at the moment. That view may change in the future.
I have no widgets set in "Skin Settings -> Edit Main Menu -> Music", hence the reason for asking.
TIA,
Dan / Gib.
@mistervee
Final post / report for tonight - I promise! (lol):
In the Music Library, under the "Square Wall View -> Sideblade -> View Settings", enabling the Artist "Logo" option in the "Album Artists" section is carried over to the "Albums" section. i.e: both sections are modified by this setting. I would prefer them to be kept as separate settings, much like the "Animated Background" settings (per-section) as it stands.
Reasoning: It's nice to see the artist logos with the artist thumbnails in "Artists" view. However in "Albums" view, it's not always possible to determine the album / release name simply from the cover art alone in some cases, so for this view I'd prefer to see the plain text label. Currently, it's one or the other for both sections.
TIA,
Dan / Gib.
@mistervee in the Artwork setting of the skin, it would be nice if we could see the selectet option for Audio/video Fallback CD on the right side of the panel
@Slipass
The series in view (Low) still lack the ClearArts/Logos
Now fixed.
@mistervee
Final post / report for tonight - I promise! (lol):
In the Music Library, under the "Square Wall View -> Sideblade -> View Settings", enabling the Artist "Logo" option in the "Album Artists" section is carried over to the "Albums" section. i.e: both sections are modified by this setting. I would prefer them to be kept as separate settings, much like the "Animated Background" settings (per-section) as it stands.
Reasoning: It's nice to see the artist logos with the artist thumbnails in "Artists" view. However in "Albums" view, it's not always possible to determine the album / release name simply from the cover art alone in some cases, so for this view I'd prefer to see the plain text label. Currently, it's one or the other for both sections.
TIA,
Dan / Gib.
@gibxxi
Makes sense. Not sure when i will code this. Other areas to finish first.
@mistervee in the Artwork setting of the skin, it would be nice if we could see the selectet option for Audio/video Fallback CD on the right side of the panel
@meowmoo @gibxxi @bartolomesoriano @Slipass
Now playing complete. This is for the home screen, fullscreen audio, video, tv and games. Added new options and tidied up the existing. Have a look at the home screen mediamenu, video and music OSD settings button.
Next up is to finish coding this
Not working as intended and not complete; Music and Video info dialogs
@mistervee
Hi m8, can you have a look at the "Now Playing" part of the skin m8? I have Music info set as "persistent", but I notice that the CD case and spinning CD artwork are being displayed for Video items as well, overlaying the video info already present on the main menu.
Dan / Gib.
@gibxxi
I am bit confused as you have shown a screenshot of the home screen. Music info can be only set as 'persistant' in fullscreen and has no impact on the home screen. Also you mention music, but the screenshot shows Live TV.
Can you try deleting 'userdata\addon_data\skin.madnox\settings.xml'. Might be a old setting causing a conflict?
It's not the skin settings file, this was already cleared as per your instructions as of the last (major) update. I just tried it again, no change.
I mentioned "persistent" as I've never seen this behaviour prior to setting it as such.
Can you not see the PVR info underneath the CD artwork / case in the screenshot? I showed the home screen because that's where it shows itself. I am indeed playing video, so I should not be seeing the CD artwork at all, should I?
The error only occurs on PVR streams, not on locally stored content. This might be down to (initially) Kodi detecting the stream as "audio-only" and then changing as soon as the video catches up. With my HDHomeRun box, the audio always buffers up faster than the video (and starts playing as such), I might have to get back to you on this one as it may be more of a PVR add-on issue than a skin one.
Dan / Gib.
@gibxxi
Makes sense after you explanation. I might be able to fix this with some tweaks to the code.
Drop this file in the madnox skin xml folder https://1drv.ms/u/s!AmyR0RLRGBmugrsiTJxEoVfFidtjLw?e=nDH4J3
You will just need to recreate the issue and screenshot. The xml will overlay the skin and show what media type is detected by kodi. From there i can adjust some visibility conditions.
You will see something like this https://imgur.com/9XX33Pi
@mistervee
In hindsight m8, I think the link between me selecting "Persistent" mode for MusicVis and updating with your 1st major recent update ocurred at the same time, or rather in the same run / session, so one thing probably has / had no effect on the other and was just coincidence.
However, update on the PVR issue; we thought we had a fix that could be pushed into mainline Kodi, but this issue with the displaying of info types has caused the developer to rethink whether his code was adequate enough to merge with mainline.
My usage is certainly an edge-case scenario because I'm not only using a HDHomeRun (HDHR4 - Connect) device, but also do my networking over Powerline predominantly, and that comes with it's own set of caveats.
While I have the (enforced) QoS set to prioritise audio / video, other things can cause issues with transfers across multiple devices. The crux of the matter is though, that audio generally streams faster, and quicker than video. Kodi analyses stream data in order to determine what type of stream it is it's receiving, and bases it's display & processing based on that determination, in as far as I understand it (how it was explained to me). So the audio always wins out initially, as that is lower bitrate and needs less bandwidth to fill up any active buffer / connection between the two endpoints.
This check is not necessary for local content because the file format & attributes determine the content type, so Kodi has no need to "probe" the stream / file in the same way to determine what type of stream (audio-only or audio & video) it is. Also, Kodi will initiate "playback" as soon as it feels it has enough data to do so reliably, after it has made a determination (assumption) about the nature of the stream being audio-only or audio and video, at least in the case of PVR. That doesn't mean it's making the right choice / determination in every case.
What may be a solution, in as far as (potential) skin-side mitigation, is perhaps to perform a check each time the user enters the home screen, and decide what's displayed as "Info" on the home screen, based on that check. I'm thinking out loud here, as i'm not a coder, just logical thinking. Some widgets I (used) to use, did checking each time you entered the home screen, and while this could potentially cause a micropause, that (to my mind) would be a more preferable outcome, than the wrong or both sets of info being displayed.
Just about to test your custom XML, or I will be if OneDrive stops freezing up Windows Explorer so I can actually navigate to the downloaded file! Next post will contain the desired screenshot. Watch this space.
;)
P.S: Sorry if I came across a bit curtly in my previous post, I've been battling issues with the HDHomeRun and PVR in Kodi for a long time, and it's been a somewhat frustrating journey.
Dan / Gib.
@gibxxi Sounds frustrating indeed. No problem at all, i didn't think you seemed curtly.
Something i noticed with a delay,
I use Next PVR, When starting a live tv stream, it is detected as audio for a fraction of a second, then detected as video. Visually i can't see anything on the home screen as the delay is too short. This is a local client. It would make sense for the delay to be longer, depending on what your network speeds are like.
I also have an issue with kodi, if you are playing a radio channel, then switch to a tv channel, the music fullscreen shows for about two second then switches to video fullscreen.
This is either a pvr backend issue or kodi issue. I don't know much about the plugin api but if the backend can force 'Player.HasVideo' when starting a live tv stream then the problem could be solved.
For coding i can add some extra visibility conditions to try to minimize the problem.
@gibxxi
Some further investigation,
While playing livetv then switch to pvr radio, kodi shows fullscreen video for the radio.
I tried this with next PVR then MediaPortal backends. Both have identical results.
So generally livetv is always detected as audio first and then switches to video causing some strange behaviour no matter what skin i try.
Once i get your screenshot, i will have to ask on the kodi forums. Seems to be effecting multiple backends.
@mistervee
Working on it now m8, but I have a feeling yesterday's update may have inadvertantly fixed it (at least for me), bear with me...
Dan / Gib.
@mistervee
Here is a screenshot from one of my systems running Kodi with the Madnox 2.0 skin that had not yet recieved yesterday's updates:
Here's a screenshot of the same system, after yesterday's updates have been applied:
Please bear in mind that my initial report (also yesterday) was prior to applying updates to any of my systems. Your update (and subsequent post, here) reminded me to report the issue.
Having said that, It is the case that there are "issues" with the PVR Kodi module, in as far as I see it, based on evidence and personal experience. Game-breaking issues? No. But issues nonetheless. You might want to trawl through the thread on the Zuki HDHomeRun DVR GitHub page (or you may not, lol), but if you want to understand how both me and djp952 (Michael Brehm) got to where we are now, it would be a good idea.
It might also be an idea to invite him as a tester here (He has a Kodi forum account) so he can do his own first-person testing, and at the same time relieving me of the task of having to act a bit like a go-between (and retyping everything twice, lol).
https://github.com/djp952/pvr.hdhomerundvr/issues/65
Dan / Gib.
@gibxxi
Before yesterday's update, now playing was not finished. So the report you provided was something that could be expected.
The info on screen looks ok. All the infolabels showing what they should be on both screenshots. The issue was visibility conditions in skin code, that were fixed with the recent update.
There still is the issue with kodi or pvr backends. Might have a workaround for it. I will post over in the other thread my findings.
@mistervee
Roger that m8. If you should require my help, let me know.
Dan / Gib.
@mistervee
Hi m8, we have a regression with regards the home screen TV/Radio channel icon scaling on the back of the last update, Icons are back to where they were before (not being scaled on the home screen, whereas they are in MusicVis).
Also, would it be possible to get rid of the spinning CD in both views for PVR / internet-based streams? To my mind, even though it's audio, being an internet-based stream the presence of the spinning CD seems a bit redundant to me, not withstanding the fact it'll never get replaced with CD cover art due to the fact it is an internet stream, and not local audio (i.e: ripped from local CDs).
Dan / Gib.
@gibxxi
Just checked the code. A disc will only show for movies and music videos, and the aspect will be maintained for PVR/Internet streams. Can't see any reason why that would happen.
Can you provide a screenshot with the custom overlay with the issue?
@mistervee
Hi m8, In the case of the HDHomeRun, there are no seperate categories for TV and Radio PVR channels. Everything is lumped into the same category (Hence the reason, for me, the "Radio" category is somewhat redundant). Anyway, here are the screenshots of the Radio Channel BBC Radio 5 Live:
Home Screen: https://imgur.com/cYJtxWS
MusicVis: https://imgur.com/Ofh8YdQ
EDIT: Now with the right images. ;)
Dan / Gib.
@gibxxi
Found the issue. Radio channels are being played as livetv, fixed the visibility conditions. I didn't have the issue due NextPVR having separate radio/tv sections.
Updated github with fix.
@gibxxi
Found the issue. Radio channels are being played as livetv, fixed the visibility conditions. I didn't have the issue due NextPVR having separate radio/tv sections.
Updated github with fix.
@mistervee
Excellent. Thanks m8.
:)
Dan / Gib.
@mistervee
When playing a playlist (m3u) of tracks from the scraped library, cover artwork and artist logos are displayed, but CD artwork isn't (default blank CD shown instead), even though 'discart.png' images are present in-folder with the music tracks being played). Playing said same tracks from the library results in correct CD artwork being shown.
Also, in some cases (inconsistent), initiating playback of video or music items from the 'Files' section(s) doesn't always result in the switch to MusicVis and / or FullScreen video. More testing needed by me on this one.
Finally, the 'Information' context menu item, from the 'Files' section is still querying ExtendedInfo rather than EmbruaryInfo (resulting in an ExtendedInfo error popup dialog).
Dan / Gib.
@mistervee
Library View -> Albums -> Tracklist:
MusicVis (From Above View) -> Play Track:
Playlist -> Tracklist (m3u) View:
MusicVis (From Playlist / Tracklist) -> Play Track:
Dan / Gib.
@mistervee Hi, im sure you working hart on the skin, and im not sure whats the current status so I`m just gonna point out what i notice/want
in skin settings furniture the description for the last 3 settings is wrong, Jump to letter shows the plot description, plot outline the auto scroll, and auto scroll shows nothing
Artwork, its impossible to install Colored Studio icons, colored movie genre, BW movie genre, and movie Country icons, everything else works.
Colors, if you change the color platte, it need to reload all the colors again, would be nice if the get "cached" and show instant next time.
will the Save/load day/night feature from an early release be back at the end? i like the idear of sharing themes or just save it and use different colors for a while and than load the "old" one again.
the "letterbar" takes very long to load on my end, not sure if you can do anything to speed it up.
In the info list 2 view it should show poster and fanart but it shows poster and (scaled) poster https://imgur.com/Va2t9V9 this across all media Movie/Tv/Music
The simple list for music looks a bit empty, if possible a cd count on the right side would be nice.
An option to lock the homescreen settings,beside from kiosk mode would be welcome, i often browse my widget and if I press left to often I end up in the Setting for the Homescreen.
the 4k logo did not work, i added a few 4k movies to my lib, and non of them shows the 4k logo, in Estuary it works https://imgur.com/XHmBvj6 https://imgur.com/EUoHJce
thats all i have found on my daily use for now.
again I cant stress enough how thank full i am that you put all this work and time into Madnox v2 im using it every day and are very happy with it. There is no other skin that looks and feels close as good as madnox!
THANKS and a Good new Year
2 more things :D
would be nice to see the Background texture option for the now playing screen also or make the skin option affect the now playing screen so its one solid look throughout the skin
a option to show the Movie/tv/artis name in a lower corner on the homescreen for the current fanart would also very welcome, my SO often ask "what is this for a movie looks cool" and 50% of the time i dont know :P
@bartolomesoriano @gibxxi @meowmoo @Slipass
An update.... The skin is 90% for an alpha release, i am determined to have it ready for the forums by
Christmassometime in the future.What needs to be finished....
Code Optimization
Clean up and rearrange the includes and variablesSkin functions that are not complete
Now Playing - Home screen, Fullscreen music and videoSkin backgroundsInformation dialogs recode and support for TheMovieDb helper and Embuary info (partially done for videos) Done, removed online support, maybe add it back at a later time.Fallback artwork for library viewsKodi Profile selectionCode Embuary Info Actors/Videos xml'sCode Next Aired xmlCode RSS editor and add to optional addonsCode UP Next addon and add to optional addonsWatched flags for widgets and library viewsOther
Review feature requests and bug reports on github in "issues"Add search options using dynamic contentIf there is anything you think i have left out please let me know.
I really appreciate your help. TY all. Cheers Mr. V