search

mistervee / skin.madnox

Other
13 stars 13 forks source link

Current status of the skin #44

Closed mistervee closed 4 years ago

mistervee commented 5 years ago

@bartolomesoriano @gibxxi @meowmoo @Slipass

An update.... The skin is 90% for an alpha release, i am determined to have it ready for the forums by Christmas sometime in the future.

What needs to be finished....

Code Optimization

Skin functions that are not complete

Other

If there is anything you think i have left out please let me know.

I really appreciate your help. TY all. Cheers Mr. V

mistervee commented 4 years ago

The only sort option that removes the '0.000000 B' size indicator (replaced by date added) is 'sort by date'. But this does not sort the items alphabetically (obviously), so finding specific titles / folders in the list becomes harder. I will put up with it if it's not something you can / want to change.

Sort by name works for me. It does not show size.

EDIT:

With reference to my previous comment, I forgot to point out that I am NOT using NFO files with my media. The software I use to categorize and standardize the file naming stucture (and some limited artwork downloading) does not add actor information to the NFO files it creates. Once In Kodi, and after library scraping, it seems Artwork Beef will not download actor images if this information isn't present in the NFO file itself (in so far as I understand it). So with this in mind, and the fact I am (more than) a bit OCD, and that I hate percieved unnessecary clutter files, I removed all the NFO files from everything and let Kodi itself handle grabbing the relevant information from the installed scrapers I use (TMBD / TVDB). This probably explains why there are no media flags at higher levels in the Kodi library-tree for me, not to mention the delay at which the duration information is retrieved (from the physical files) at a guess.

I do not use nfo’s myself. Just the kodi database and it works. If I am missing info labels I will load up ‘DB Browser for SQLite’ and check if the info is in the database. Missing labels for me are just an issue with kodi not having the info from the default scrapers.

mistervee commented 4 years ago

@gibxxi @bartolomesoriano @meowmoo @Slipass

Update to git.

Support for embuary info actors/movie info/tv info complete. This now makes the skin feature complete.

Now time for cleanup/optimization/bug fixes prior to alpha release.

Cheers Mr. V

EDIT: Need to create a custom search window too.

gibxxi commented 4 years ago

@mistervee

Sort by name works for me. It does not show size.

That's the setting I was using at the point the screenshot provided was taken, which must mean it's something my end then. However, I've seen this since before the last database wipe, and since, so i'm skeptical it's database-related. However, I did have a brainwave after reading your reply. I still have Marcel Veldt's helper addons and ExtendedInfo installed, as they are required by another skin I have installed (Arctic Zephyr MOD by BeatmasterRS). So I think either one of those, or some other rogue addon is to blame. I have removed some orphaned addons today, after running through the list, but am holding off a clean-out / fresh install until 'Matrix' goes live.

I will at that point be starting again, with a completely clean install (no carry-overs) since that upgrade will likely render a lot of the 'un-maintained' addons & repos I have currently installed unusable. I don't want to have to do this now, and again when Matrix comes down the pipe, so if your saying you don't see what I'm seeing, I trust you to be telling the truth and will put up with it until such times as I can / am prepared to start afresh.

I have had a nasty habit in recent times of installing stuff from the Kodi repo, that 'may be useful one day', when in reality it makes more sense to keep Kodi as slimline as possible. You live and learn I guess.

I may do some more digging, but your confirmation that this doesn't seem to be skin-related, or at least, 'Madnox-related' is enough for me.

Honest feedback is what I like. I will do the same.

Thankyou for your understanding.

:)

Dan / Gib.

meowmoo commented 4 years ago

I'm sure translation comes to the end but since it's the only thing I notice... In the videoinfo, if the movie is in a set, the set's button translate to "einstellen" because set is einstellen in German, but if it's a movie set it's a "Kollektion" so the button should translate to "Kollektion"

Is there a way to speed up the actor loading? I played around with the tmdb/embuary helper option but had no luck.

Is it supposed to only show the unwached number without the unwached circle? Showing both the circle and the number would be better fitting in my opinion.

In the context menu are 2 tmdbhelper settings, as I prefer it simple both are unnecessary for me, and I would like to not see them If possibly.

There is one thing I'm missing I (was) kinda used to, on the video progessbar on the left side it shows "actual time / total time" I would prefer "actual time / remaining time" so you can see with in a sec how log the movie last, if the tired Wife is asking 😅 @mistervee

mistervee commented 4 years ago

@meowmoo

I'm sure translation comes to the end but since it's the only thing I notice... In the videoinfo, if the movie is in a set, the set's button translate to "einstellen" because set is einstellen in German, but if it's a movie set it's a "Kollektion" so the button should translate to "Kollektion"

The 'Set' button name is using the english language that is in Kodi language pack. There is no translation for 'collection'. You can create custom movie sets and 'set' is the name used in kodi. The translation is kept for consistency. Something I won’t be changing unless Kodi decides to rename it to collections.

Is there a way to speed up the actor loading? I played around with the tmdb/embuary helper option but had no luck.

I can speed up actor loading. Currently it is using embuary info, so that is why you see a delay. Just put it on my to do list.

FYI For the TMDB info options;

  1. If you enable ‘TMDB actor info’ it will show info from the internet when you click on an actor.
  2. If you enable the ‘TMDB info’ button, when you click on the button it will get info about the movie from the web.

Is it supposed to only show the unwached number without the unwached circle? Showing both the circle and the number would be better fitting in my opinion.

From my end it is working. Can you post a screenshot?

In the context menu are 2 tmdbhelper settings, as I prefer it simple both are unnecessary for me, and I would like to not see them If possibly.

That is from the TMDB helper script, so I can’t remove them from the skinning side of things. I have them too and cannot see any way to disable them.

There is one thing I'm missing I (was) kinda used to, on the video progessbar on the left side it shows "actual time / total time" I would prefer "actual time / remaining time" so you can see with in a sec how log the movie last, if the tired Wife is asking 😅

Done. Option added in fullscreen video settings.

mistervee commented 4 years ago

@gibxxi @bartolomesoriano @meowmoo @Slipass

Update on git;

mistervee commented 4 years ago

Screen shots of search fuctions.

NOTE: WIP. Media menu not working. Some labels like the duration are not working.

1 2

meowmoo commented 4 years ago

OK, I will update/reinstall the skin and check the unwatched circle again. If it's still missing I provide a screen shot.

@translation, if it's a kodi "issue" I will post in the forum about it. Same for tmdb helper.

I did know about the tmdb online info, I use it from time to time, it's a nice feature.

Thanks for adding my request! @mistervee

mistervee commented 4 years ago

@gibxxi @bartolomesoriano @meowmoo @Slipass

I am number of hours of coding away for an alpha release to the Kodi forums. Over the past few years your input has helped me get to where the skin is today. There is no way I could not have done it without you. Thankyou a million times over. Thankyou, Thankyou, Thankyou, Thankyou.

I still need to finish the search function and tidy up the code. The search will be disabled in the next update before release. The code tidy up and search will happen after release. This thread will be closed soon and a new one opened with a to do list. Soon is over the next couple of days.

When this happens, this repo will no longer be private and I will update the info in the forums with the link to the skin.

If you want to stay involved feel free to help answer any questions on the forums.

Cheers and Thank you all Mr. V

P.S. Thank you for your time, effort and sticking with me of these past few years. :thumbsup: :thumbsup: :thumbsup: :thumbsup:

gibxxi commented 4 years ago

@mistervee

Well done Mr. V. Thank you for giving us the opportunity to sample this skin during it's development, and letting us have input and feedback on it's progress. It has been a pleasure to see it mature like it has done.

Quick question: Do you plan on having a a Kodi repo for automatic updates so that manual syncing via Github is no longer required?

Dan / Gib.

mistervee commented 4 years ago

@gibxxi

TBH i never thought of it.

I don't know how to make a custom repo, but i will see if i can figure it out as is does make sense to do this.

meowmoo commented 4 years ago

@mistervee after reinstall the skin, the unwatched problem is sloavede,

Slipass commented 4 years ago

@gibxxi @bartolomesoriano @meowmoo @Slipass

I am number of hours of coding away for an alpha release to the Kodi forums. Over the past few years your input has helped me get to where the skin is today. There is no way I could not have done it without you. Thankyou a million times over. Thankyou, Thankyou, Thankyou, Thankyou.

I still need to finish the search function and tidy up the code. The search will be disabled in the next update before release. The code tidy up and search will happen after release. This thread will be closed soon and a new one opened with a to do list. Soon is over the next couple of days.

When this happens, this repo will no longer be private and I will update the info in the forums with the link to the skin.

If you want to stay involved feel free to help answer any questions on the forums.

Cheers and Thank you all Mr. V

P.S. Thank you for your time, effort and sticking with me of these past few years. 👍 👍 👍 👍

@mistervee Thanks for letting us support you with our input for the skin.

You had the most work!

I am looking forward to provide input in the future.

Greeting

meowmoo commented 4 years ago

@mistervee your very welcome! I'm the one who have to say Thank you! Madnox is by far the best skin and I don't know what I have done if you haven't spend the last years of recoding my favorite skin! THANK YOU very much!

I will for sure stick around and help out when I can!

bartolomesoriano commented 4 years ago

@mistervee , you are very welcome indeed! Thank you for letting me participate in this journey with you, and for teaching me so much! And, of course, thank you for Madnox!!!!! I will also be around and help anyway I can.

gibxxi commented 4 years ago

@gibxxi

TBH i never thought of it.

I don't know how to make a custom repo, but i will see if i can figure it out as is does make sense to do this.

@mistervee @djp952

I know that djp952 (HDHomeRunDVR - Zuki plugin author) has his installable addon also double as a repo at the same time, or at least that seems to be the case, as his DVR addon isn't in the official Kodi repo (AFAIK) and I still get automatic updates for it without having install a 'dedicated' repo seperately.

BTW, I was in a rush this morning when posting my inital comment, so as the others have alluded to, THANK YOU very much for your trust and patience in us on this epic journey. Aeon (Mad)nox lives on, thanks to your efforts, so thank you very much for taking on this emmense undertaking.

🥇 👍

A minor bug report to finish up, lol. You remember my previous posting about unselectable buttons in some menus, where there were no editable settings? Getting a similar issue with the Internet (Audio) stream OSD. When pressing [ENTER] to display the drop-down OSD (from top of the screen), none of the round buttons / icons at the top are selected / highlighted by default, so cursor / remote control navigation through the OSD panel isn't possible, unless you move the mouse over the panel, whereby normal function can be resumed.

Regards,

Dan / Gib.

djp952 commented 4 years ago

Setting up a custom repo was more trial and error than anything else. For something like a skin I'm guessing it's the same files for all the platforms (Windows/Linux/etc)? That should make it much easier than what I ended up doing, which was a separate "manifest" for each possible platform. That allowed to automatically generate the XML file(s), which was nice.

BUT: Basically all you need to do is add an entry into your addon.xml indicating where the repository to check for updates is, and then put the manifest(s) at that location.

Again, mine is a binary PVR addon, but as an example, here is what gets added to the addon.xml:

<?xml version="1.0" encoding="utf-8"?>
<addon id="pvr.hdhomerundvr" version="3.3.2a" name="HDHomeRun DVR PVR Client" provider-name="Michael Brehm (djp952)">
   ....
    <extension point="xbmc.addon.repository">
        <info>https://raw.githubusercontent.com/djp952/repository.hdhomerundvr/Leia/windows-x64.xml.gz</info>
        <checksum verify="sha256">https://raw.githubusercontent.com/djp952/repository.hdhomerundvr/Leia/windows-x64.xml.gz.sha256</checksum>
        <datadir>https://github.com/djp952/pvr.hdhomerundvr/releases/download</datadir>
        <artdir>https://github.com/djp952/pvr.hdhomerundvr/releases/download</artdir>
        <hashes>sha256</hashes>
    </extension>
   ....

The repository itself uses XML as well, but also needs a .sha256 checksum file, as you can see in above XML. (MD5 is no longer supported by Kodi). You can see the ones I have here:

https://github.com/djp952/repository.hdhomerundvr

NOTE: On "Leia" branch there is also an older "addons.xml.gz" file - that was the old way I did it, lumping all the platforms into one big file. Grab, extract, and look at "windows-x64.xml.gz" for the manifest that matches the above snippet. You'll see it's pretty similar to the addon.xml:

<?xml version="1.0" encoding="utf-8"?>
<addons>
    <addon id="pvr.hdhomerundvr" version="3.3.2" name="HDHomeRun DVR PVR Client" provider-name="Michael Brehm (djp952)">
        <requires>
            <import addon="kodi.binary.global.main" version="1.0.14"/>
            <import addon="kodi.binary.global.gui" version="5.12.0"/>
            <import addon="kodi.binary.instance.pvr" version="5.10.3"/>
        </requires>
        <extension point="xbmc.pvrclient" needs_configuration="false" library_windx="zuki.pvr.hdhomerundvr.dll"/>
        <extension point="xbmc.addon.metadata">
            <summary lang="en_GB">HDHomeRun DVR PVR Client</summary>
            <platform>windows-x86_64</platform>
            <size>973932</size>
            <path>leia-3.3.2/zuki.pvr.hdhomerundvr-windows-x64-leia-3.3.2.7501.zip</path>
        </extension>
    </addon>
</addons>

For a skin, it's undoubtedly going to different in places, but in essence this is how it works. I assure you trial and error will be required to get it right, but I'm happy to assist in any way I can.

Provided you want to go this route, of course! Just saw my mention and wanted to make the offer of assistance ...

gibxxi commented 4 years ago

@djp952

Thanks for your insight Mike. I like your solution. It means I don't have to install a repo AND an addon seperately. Ellegant solution which is ideal if only 'one' addon is being offered by the repo anyway (hence the reason for linking to you in the 1st place).

;)

Dan / Gib.

meowmoo commented 4 years ago

@mistervee Can I request tmdb rating in the video info screen? http://imgur.com/a/URjV3f3 Trakt rating would be cool also, but since it get not pulled in to the db from the scanner it is not easy/possible at all?

Also as you can see in the picture the poster is a bit cut of, the A and N.

mistervee commented 4 years ago

@djp952

Thanks for the help.

I spent a few hours on this and could not get it working. I did learn a lot on how to set it up, really just some more trial and error to make it work (as you said) and i am sure i can get it sorted.

For now it will be download of the whole skin as i do not want to be concerend with version numbers or change logs.

Cheers Mr. V

mistervee commented 4 years ago

@gibxxi @bartolomesoriano @meowmoo @Slipass

I have deleted some commnets in this thread related to my medical issues.

mistervee commented 4 years ago

@meowmoo

@mistervee Can I request tmdb rating in the video info screen? http://imgur.com/a/URjV3f3 Trakt rating would be cool also, but since it get not pulled in to the db from the scanner it is not easy/possible at all?

Also as you can see in the picture the poster is a bit cut of, the A and N.

TMDb ratings added Fixed the poster with the edges being cut off.

I wont be be adding trakt ratings as that info is not availble in the kodi database.

mistervee commented 4 years ago

@gibxxi @bartolomesoriano @meowmoo @Slipass

Final update on git before alpha release.

Conversation can be continued in; https://github.com/mistervee/skin.madnox/issues/45

Cheers and thankyou all Mr. V

This thread will be closed.