search

mitodl / teachersportal

MIT ODL Teacher's Portal
0 stars 0 forks source link

Removed npm shrinkwrap file #477

Closed noisecapella closed 8 years ago

noisecapella commented 8 years ago

What are the relevant tickets?

Fixes #476

What's this PR do?

Removes npm-shrinkwrap.json which pins dependencies, but which we don't keep up to date. I'm not sure this is useful to us so it seems easier to remove it.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

I'm going to submit another PR to upgrade all dependencies and get rid of some we don't use.

Screenshots (if appropriate)

What GIF best describes this PR or how it makes you feel?

bdero commented 8 years ago

:+1: It seems like the best route to go is to trust the dependency chains resolved from our top-level pinned dependencies. Versioning this shrinkwrap seems as problematic as pip freeze > requirements.txt for python dependency tracking.

noisecapella commented 8 years ago

FYI I made a change to pin material-ui to the earlier version, which is the original reason we shrinkwrapped in the first place