search

mkhairi / jquery-datatables

Jquery datatables ruby gems for assets pipeline
https://datatables.net/
Other
75 stars 18 forks source link

Removing autoprefixer-rails as runtime dependency? #13

Closed zokioki closed 5 years ago

zokioki commented 5 years ago

Would it be a good idea to remove autoprefixer-rails as a direct dependency of the gem? It feels like something that should be included by the gem's end user on a case by case basis.

For example, the app I'm pulling this gem into is primarily an internal dashboard and does not require legacy or wide browser support. I currently manually disable AutoprefixerRails as my app has no need for it to be loaded.

Wondering what your thoughts are on this 🙂

mkhairi commented 5 years ago

hi @zokioki, master branch now not depend on autoprefixer-rails.

zokioki commented 5 years ago

Thanks @mkhairi ! Not sure if you're open to how the gem's versioned, but one thing you can do is add an extra version point for gem-specific changes like these, something like:

v1.10.19.1

This way you can still have versions pushed out that address any issues in-between dataTable's releases, while staying in line with the original library's versioning. Let me know what your thoughts are on this.

mkhairi commented 5 years ago

Hi @zokioki , v1.10.19.1 published on rubygems.org. Sorry for delayed. Btw, thanks for suggestion. 👍

zokioki commented 5 years ago

Thanks a ton @mkhairi , will close issue now 👍