Ctrl + Shift + I is a core shortcut on linux

mkxml / vscode-filesize

filesize package for Visual Studio Code

MIT License

60 stars 13 forks source link

Closed gonssal closed 6 years ago

gonssal commented 6 years ago

This extension overwrites the core default "Format Document" shortcut on linux, "Ctrl + Shift + I"

mkxml commented 6 years ago

@gonssal Thank you for reporting. I was not aware of this problem. I will think of another shortcut and ship the change in the next release.

Can you give me a suggestion that would work great on VS Code for Linux?

gonssal commented 6 years ago

Considering it's for the current file, maybe "Ctrl + Shift + ."?

mkxml commented 6 years ago

@gonssal Can you check the keybindings file to see if Ctrl+Shift+. is not used to Relace with next value on text focus?

Because on mac Cmd+Shift+. does that.

If Ctrl+Shift+. is available we should use it for Mac as well.

I'm booting up VMs to check Windows too.

gonssal commented 6 years ago

"Replace with next value" is Ctrl+Shift+< in Linux.

Before suggesting it, I checked if Ctrl+Shift+. was being used in Linux. I have all the default shortcuts.

mkxml commented 6 years ago

Unfortunately, Ctrl+Shift+. is "Replace with next value" on Windows. Just checked this.

Perhaps we can keep Ctrl+Shift+I on Windows and switch to Ctrl+Shift+. on Linux.

It would not be ideal but better than breaking core shortcuts on Linux, unless we find an universally available shortcut across platforms.

gonssal commented 6 years ago

I personally changed it to Ctrl+Shift+', but not sure how that would work on Macs.

mkxml commented 6 years ago

Used Ctrl+Shift+'. Thank you @gonssal! The new shortcut is available in 2.1.0.