mlabs-haskell / cardano.nix

Nix ❤️ Cardano
https://mlabs-haskell.github.io/cardano.nix/
2 stars 0 forks source link

precommit hooks #25

Closed avnik closed 4 months ago

avnik commented 6 months ago

Prototyping solution for #22

I not satisfied it much, because injecting into devshell is very hacky (or doesn't work with direnv, and require explicit nix develop at least once). Also still doubt, if we need it or not.

Open list of questions:

brainrake commented 5 months ago

Assigning to Milestone 2 as Milestone 1 was accepted without this.

brainrake commented 4 months ago

I have rebased, reviewed and tested this. It did need nix develop to set up commit hooks, but they worked fine afterwards. LGTM

brainrake commented 4 months ago

i think nix flake check is too heavy for pre-commit.