search

mlemesle / rustemon

A wrapper library for PokeApi, written in Rust
MIT License
27 stars 10 forks source link

Serde Serialization Compatibility? #23

Closed billy-briggs-dev closed 5 months ago

billy-briggs-dev commented 6 months ago

Hey I'm using this wrapper for a small side project and was trying to convert the Pokemon struct to an object string. I noticed that the structs do not have compatibility with Serde Serialize, would it be possible to add that to the struct definitions for flexibility?

billy-briggs-dev commented 6 months ago

PR raised: #24

mlemesle commented 6 months ago

Hey there !

Thanks for using rustemon, and thanks for reaching. I appreciate it !

Regarding your needs, it sounds kinda specific to me. Most people, in my opinion, just wants to interact with PokeAPI, they wouldn't need to serialize anything.

With that in mind, do you think you can put the serialize implementations behind a feature gate called serialize-models that will be opt-out by default ? Please let me know if you want to do it yourself or if you prefer me to do it.

mlemesle commented 5 months ago

Hey @billy-briggs-dev !

What do you think of my proposal ? Does that suit your needs ? If so, do you want to implement or you rather want me to implement it ?

mlemesle commented 5 months ago

Closing the issue because no feedback